Skip to content

[Snyk] Security upgrade js-yaml from 3.14.1 to 5.2.2 - #51

Closed
l0rd wants to merge 1 commit into
mainfrom
snyk-fix-bba8f888851b7736242c89da8efe3d9f
Closed

l0rd wants to merge 1 commit into
mainfrom
snyk-fix-bba8f888851b7736242c89da8efe3d9f

Conversation

@l0rd

@l0rd l0rd commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

  • package.json
  • package-lock.json

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Inefficient Algorithmic Complexity
SNYK-JS-JSYAML-18313070
  828  

Breaking Change Risk

Merge Risk: High

Notice: This assessment is enhanced by AI.


Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

@l0rd

l0rd commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Merge Risk: High

This is a major upgrade from version 3 to 5, which includes numerous significant breaking changes across two major releases (v4 and v5). Direct upgrade without code modification will likely cause application failure.

Key Breaking Changes in v4.0.0:

  • safeLoad and safeDump Removed: The safeLoad(), safeLoadAll(), and safeDump() functions have been removed. The main functions (load(), loadAll(), dump()) are now safe by default. All calls to the safe* methods must be renamed.
  • Unsafe Tags Moved: Deserialization of unsafe tags like !!js/function and !!js/regexp is no longer supported by default and has been moved to a separate package (js-yaml-js-types).
  • Number Parsing: The library now parses numbers according to the YAML 1.2 specification, which means octal numbers like 01234 are now interpreted as decimal. This can lead to silent data corruption if your application relies on the old behavior.

Key Breaking Changes in v5.0.0:

  • Empty Input: load('') will now throw an error instead of returning undefined. Code that checks for an undefined return value must be updated to use a try...catch block.
  • Custom Types API: The Type class and Schema.extend() have been removed and replaced with a new tags API. Any custom type definitions must be completely rewritten.
  • Dumper Options: Several dumper options like replacer, quotingType, and styles have been removed or replaced.

Recommendation: Due to the extensive and impactful nature of these breaking changes, a direct upgrade is not recommended. A thorough code review and refactoring are required to align with the new APIs for loading, dumping, and defining custom types. Please consult the migration guide for detailed instructions.

Source: GitHub CHANGELOG, v5 Migration Guide

Notice 🤖: This content was augmented using artificial intelligence. AI-generated content may contain errors and should be reviewed for accuracy before use.

@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: l0rd

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Ignore keyword(s) in the title.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a4c8e570-048c-4e4e-b22a-488c8b7c5c1d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch snyk-fix-bba8f888851b7736242c89da8efe3d9f

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@caniszczyk caniszczyk closed this Jul 31, 2026
@caniszczyk

Copy link
Copy Markdown

✅ This PR has been automatically closed

The security issues addressed by this pull request are no longer present in the latest project scan. All vulnerabilities this PR was created to fix have been resolved through other means (e.g., dependency updates, direct fixes, or changes in vulnerability data).

Resolved Issues

  • SNYK-JS-JSYAML-18313070

What should I do?

No action is required. If you believe this PR was closed in error, you can reopen it and contact Snyk support.


This action was performed automatically by Snyk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants