Skip to content

fix: prune botocore service models from lambda dockerfile - #186

Merged
kafitzgerald merged 1 commit into
mainfrom
fix/lambda-size-limit
Oct 6, 2026
Merged

kafitzgerald merged 1 commit into
mainfrom
fix/lambda-size-limit

Conversation

@kafitzgerald

@kafitzgerald kafitzgerald commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Following the approach from #151 prunes botocore service models from the lambda Dockerfile. Needed for #184 which is currently just over the size limit for the CDK stack.

Testing

None

PR checks

  • Standard CI runs automatically on each push.
  • To run the CDK synth check, add the run-cdk-checks label to this PR.
  • If you push more commits after that run completes, remove and re-add the label to run it again.
  • To trigger a dev deployment, add the deploy-dev label. It smoke-tests tiles from the native MUR, virtual MUR, and virtual NLDAS Icechunk stores after deployment.

@github-actions github-actions Bot added the fix label Oct 6, 2026
@kafitzgerald
kafitzgerald force-pushed the fix/lambda-size-limit branch from 673590f to e201c9b Compare October 6, 2026 17:04
@kafitzgerald
kafitzgerald marked this pull request as ready for review October 6, 2026 17:24

@maxrjones maxrjones left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this is a more comprehensive pruning that we could use:

https://github.com/developmentseed/titiler-cmr/blob/316642b7191f6f8a30fc76e24aeebc34e6d13a9a/infrastructure/aws/lambda/Dockerfile#L170-L184

It might be worth testing out

@kafitzgerald

Copy link
Copy Markdown
Contributor Author

I wonder if this is a more comprehensive pruning that we could use:

https://github.com/developmentseed/titiler-cmr/blob/316642b7191f6f8a30fc76e24aeebc34e6d13a9a/infrastructure/aws/lambda/Dockerfile#L170-L184

It looks like we already have most of this with the exceptions of fully removing boto3 and botocore, but those seem to be needed here (unless the comments are incorrect).

@maxrjones

Copy link
Copy Markdown
Member

I wonder if this is a more comprehensive pruning that we could use:
developmentseed/titiler-cmr@316642b/infrastructure/aws/lambda/Dockerfile#L170-L184

It looks like we already have most of this with the exceptions of fully removing boto3 and botocore, but those seem to be needed here (unless the comments are incorrect).

oh gosh yeah, sorry about that. I should've looked more at the surrounding code.

Assisted-by: Claude (Anthropic)
Co-authored-by: Max Jones <14077947+maxrjones@users.noreply.github.com>
@kafitzgerald
kafitzgerald merged commit 8f49613 into main Oct 6, 2026
13 checks passed
@kafitzgerald
kafitzgerald deleted the fix/lambda-size-limit branch October 6, 2026 21:27

This branch was successfully deployed

1 active deployment
dev — 4070431c Deployed Oct 6, 2026 by kafitzgerald via Deploy to dev #330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants