Conversation
XarrayMosaicBackend opened every source to validate mosaic compatibility, closed it, and rio-tiler's tile/part/point paths then opened it again. For a large Icechunk store each open costs ~1.5s, which doubled tile and point latency. Keep the validation readers open for the life of the backend, route rio-tiler's per-asset reader calls to them, and close them when the request's backend context exits (or when validation fails part-way). Duplicate URLs now share one reader. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
/info?show_times=true opened the dataset a second time to read its time coordinate; read it from the reader the mosaic backend already holds open. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR keeps readers open for the duration of the backend, to be shared for both validation and rio-tiler's calls. It also makes it so URLs provided multiple times to the mosaic route share one reader.
This is motivated by poor performance observed in the AIR4US portal, which Slesa tracked to multiple openings of the same dataset. This is expensive in high-latency environment, especially for Icechunk stores where opening is a more expensive operation.
Separately, we could explore sharing open datasets across requests, but that requires a more comprehensive solution.
Testing
PR checks
run-cdk-checkslabel to this PR.deploy-devlabel. It smoke-tests tiles from the native MUR, virtual MUR, and virtual NLDAS Icechunk stores after deployment.