fix: provide legacy escape to fputcsv() for PHP 8.4/8.5#1835
Open
AllWorkNoPlay-95 wants to merge 1 commit into
Open
fix: provide legacy escape to fputcsv() for PHP 8.4/8.5#1835AllWorkNoPlay-95 wants to merge 1 commit into
AllWorkNoPlay-95 wants to merge 1 commit into
Conversation
PHP 8.4 deprecates calling fputcsv() without an explicit $escape; the default will change in 8.5. Pass the legacy escape ('\\') to all CSV export/import-report writers to keep current behavior and silence the deprecation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descrizione
A partire da PHP 8.4 chiamare
fputcsv()senza il parametro$escapeesplicito è deprecato, perché il valore di default cambierà in PHP 8.5. Su PHP 8.5 questo genera un errore visibile all'utente durante l'import/export CSV:Questa modifica passa l'escape legacy (
escape: '\\') a tutte le chiamatefputcsv()del progetto, preservando il comportamento di escaping attuale e silenziando la deprecazione. Nessuna modifica funzionale.File toccati:
src/Importer/CSVImporter.php(CSV di esempio e report delle righe fallite durante l'import)modules/articoli/src/Import/CSV.phpmodules/listini_cliente/src/Import/CSV.phpmodules/impianti/src/Import/CSV.phpmodules/liste_newsletter/actions.phpmodules/anagrafiche/bulk.phpNessuna dipendenza aggiuntiva richiesta.
Risolve: nessuna issue collegata.
Tipologia
Checklist