fix(import): pass escape arg to fputcsv in CSV example generation#1834
Open
AllWorkNoPlay-95 wants to merge 1 commit into
Open
fix(import): pass escape arg to fputcsv in CSV example generation#1834AllWorkNoPlay-95 wants to merge 1 commit into
AllWorkNoPlay-95 wants to merge 1 commit into
Conversation
PHP 8.4+ deprecates fputcsv() without an explicit $escape parameter. Whoops promotes the deprecation to a thrown exception, aborting createExample(); the import module then returns a JSON error that the frontend navigates to, yielding a 404 on the "Scarica esempio CSV" button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descrizione
Il pulsante "Scarica esempio CSV" nel modulo Importazioni restituisce una pagina 404 / Not Found anziché scaricare il file di esempio.
Causa: su PHP 8.4+ la chiamata
fputcsv()senza il parametro$escapeemette unE_DEPRECATED("the $escape parameter must be provided as its default value will change"). Poichécore.phpregistra Whoops come gestore degli errori, la deprecazione viene promossa a eccezione e interrompeCSVImporter::createExample(). Il moduloimportcattura l'eccezione e restituisce un JSON di errore che il frontend (window.location = data) tenta di aprire come URL, generando il 404.Fix: passare esplicitamente
escape: '\\'afputcsv()increateExample(), mantenendo il comportamento storico (PHP ≤ 8.3) e silenziando la deprecazione.Nessuna dipendenza aggiuntiva.
Risolve: #(nessuna issue collegata)
Tipologia
Checklist