Repository navigation
Conversation
Behavioral baseline at Controller resources are deliberately excluded by the existing Pod rules. The CNPG label selector disables autogen for the entire current ClusterPolicy. An initial attempt to name nonexistent autogen rules exposed the CLI's misleading passing Excluded rows; the evaluation gate rejected them, and the corrected fixture passes that gate. This does not claim controller-template protection. The two new weakening controls run in the existing CI regression family and must reject a permissive copy of each general rule. Their execution and the complete suite remain pending in CI attempt 1; the local focused checks preceded those script additions. No production policy or enforcement setting changed. This is the test-first increment for #5133; the format migration in #4996 remains open. Current-head review and complete green CI are still required before promotion. |
@coderabbitai review |
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 39 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Hosted behavioral acceptance at The host-access fixture's 25 assertions passed. Ordinary Pods and explicit false values were accepted; the expected host-path, host-network, host-PID and host-IPC denials, exact namespace exemptions and provisioner-name lookalike checks all matched. The existing user-namespace assertions also passed. The deliberate weakening of each general rule was rejected ( I evaluated the observed CLI results as the policy maintainer: this now supplies a usable baseline for the later rewrite, including a check that would catch either general rule becoming permissive. Controller templates remain outside this policy's current scope; the selector disables autogen, and their exclusions do not establish controller protection. No production policy or failure action changed, and #4996 remains open. This completes the previously pending hosted behavioral evidence. Review and readiness are assessed separately from this receipt. The separate required code-quality rule is still reported as unverified by the completeness helper; this comment does not clear it. |
Why
The host-access policy must keep the same protections when it moves to the policy engine's new format. Its current checks cover only one of its three rules, leaving the rewrite without a complete baseline.
What
Adds checks for allowed and denied host access, infrastructure exceptions and the policy's current scope. Deliberately weakened copies must fail the checks before a later rewrite can rely on them.
Fixes #5133
Part of #4996