Skip to content

GHCR node credential rollout fails when a node changes during the rollout #5016

Open

Description

@devantler

🤖 Generated by the Agentic Engineer (interactive Claude Code session)

Evidence

Found by the merge-queue failure count in #4993.

  • 3 failed merge-group runs on 2026-09-20 failed in the deploy job's GHCR node credential rollout: the node identity or cordon state changed during the rollout, or the registry credential was not accepted.
  • Both affected pull requests later merged with no new push.
  • Evidence basis: check annotations only; no logs were read.
  • Examples: 35503104796, 35505627116, 35524936547.

Problem

A node change that the candidate did not cause evicts it. The window shows one burst; whether it can recur is not known.

Expected behaviour

A node that something outside the deploy replaces or cordons during the rollout is handled as a known state, and only a real credential failure fails the deploy.

Acceptance criteria

  • Read the logs of the runs above and record which condition failed in each.
  • Decide whether the rollout can treat that condition as expected; fix it with a test if so, or close this issue with the reason if not.

Size: small. Part of #4979.

Activity

  1. added theissue type on Oct 17, 2026
  2. coderabbitai commented on Oct 17, 2026

    @coderabbitai
    Contributor
    ⚠️ Possible Duplicate Issue(s)

    📝 Issue Planner

    Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.

    • Create Plan

    🧪 Issue enrichment is currently in open beta.

    You can configure auto-planning by selecting labels in the issue_enrichment configuration.

    To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

    issue_enrichment:
      auto_enrich:
        enabled: false

    💬 Have feedback or questions? Drop into our discord!

  3. moved this to 📥 Backlog in 🌊 Project Boardon Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Priority

    None yet

    Effort

    None yet

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions