fix(telemetry): stop the cleanup test leaking never-ending processes

[devantler]

🤖 Generated by the Agentic Engineer

Why

Every local run of the telemetry self-test leaves two background processes running forever on the agent host. 26 had piled up by today, and scheduled runs are not allowed to end them.

What

The cleanup test now looks up the real directory-removal command before swapping in its stand-in, so the stand-in hands over to the real command and ends. The stand-in also refuses to hand over to itself, so the same mistake cannot loop again.

Fixes #4354

[devantler]

🤖 Generated by the Agentic Engineer

@coderabbitai review

[coderabbitai]

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Repository YAML (base), Organization UI (inherited)
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 96562ac1-c359-4001-968f-e34a662ef668

📥 Commits

Reviewing files that changed from the base of the PR and between ac68c0b and f4ead08.

📒 Files selected for processing: 1

• .claude/scripts/agent-telemetry.test.sh

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[devantler]

🤖 Generated by the Agentic Engineer

@codex review

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-19T20:29:28.892769Z	f4ead08	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: f4ead0830e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[devantler]

🤖 Generated by the Agentic Engineer

Readiness at head f4ead0830e78dcf7cb1c2acba65f5c5bde9f081b:

• RED (before): a bash probe reproduced the cause. With the stand-in first on the search path, resolving the real command in the same command line returned the stand-in itself. On the host, 26 never-ending stand-in processes from earlier runs were running.
• GREEN (after): the same probe with the lookup hoisted returns the system command. The telemetry self-test passes locally (397 s), and after that run no new stand-in process was left running.
• Affected self-tests: 13 of 14 pass locally. The plugin-scan test refuses to run without the plugin submodule checked out, which this worktree does not have; it passes in CI.
• CI: 108 check-runs at this head, 28 success and 80 skipped, none failed. Shellcheck finding count unchanged.
• Review: CodeRabbit was rate-limited at this head (no-gate guard ADMIT); Codex reviewed this exact head with no findings. 0 review threads.