Skip to content

docs(deps): record why desktop/ is not a Dependabot directory - #7198

Merged
devantler merged 1 commit into
mainfrom
claude/deps-record-desktop-module-mechanism-6816
Sep 23, 2026
Merged

devantler merged 1 commit into
mainfrom
claude/deps-record-desktop-module-mechanism-6816

Conversation

@devantler

Copy link
Copy Markdown
Contributor

Why

People keep rediscovering why grouped dependency updates seem to skip the desktop app's module. The real reason is that Dependabot never updates that module, and the step that actually keeps it in sync is written down only in the CI workflow, not next to the Dependabot config where people look.

What

Adds a short explanation to the Dependabot config. It says why the desktop module is deliberately not listed, which CI step keeps it in sync on every dependency PR, and what that costs (tracked in #7140). The config itself does not change.

Fixes #6816

🤖 Generated with Claude Code

https://claude.ai/code/session_011Aut24ni8XbKPYyY5mYrbb


Generated by Claude Code

The gomod entry covers the root module only. desktop/ lists every
dependency it shares with the root as indirect, and version updates
touch direct dependencies by default, so Dependabot never updates it,
grouped or not. CI's desktop-only tidy commit keeps it in step instead
(#6974). Record that mechanism and its cost (#7140) next to the config.

Fixes #6816

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011Aut24ni8XbKPYyY5mYrbb

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer (interactive Claude Code session)

Evidence at head 658ccb36d3aa50d286cefd3e6bddc31e9da4a13c

No runtime surface. The change adds YAML comments only, so what Dependabot parses is unchanged. The parsed configuration (yq -S -c .) hashes to 80db48ea…93af on both main (1cf4577) and this head. RED/GREEN does not apply.

Validation run here: YAML parses, prettier@3 --check .github/dependabot.yaml passes, and every added line is at most 84 characters, within the length the file already uses. MegaLinter (yamllint) could not run here and is left to CI.

The facts recorded, checked against live state rather than memory:


Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

✅MegaLinter analysis: Success

✅ Linters with no issues

actionlint, bash-exec, git_diff, hadolint, jscpd, jsonlint, lychee, markdown-table-formatter, markdownlint, prettier, prettier, shellcheck, shfmt, stylelint, syft, trivy-sbom, trufflehog, v8r, v8r, yamllint

Notices

⚠️ Your configuration references items that have been removed from MegaLinter and are ignored: REPOSITORY_GITLEAKS. See Removed linters to find their replacements.

See detailed reports in MegaLinter artifacts

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai review


Generated by Claude Code

@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Rate Limit Exceeded

@devantler have exceeded the limit for the number of chat messages per hour. Please wait 4 minutes and 36 seconds before sending another message.

@devantler devantler left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Generated by the Agentic Engineer

Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)

Reviewed commit: 658ccb36d3aa50d286cefd3e6bddc31e9da4a13c

  • CodeRabbit: requested at this head at 2026-09-22T21:33Z (comment 5784529584); replied "Rate Limit Exceeded … number of chat messages per hour" at 2026-09-22T21:33:37Z (comment 5784531375), so no review at this head
  • Codex: usage limit reached (measured 2026-09-22T20:53:06Z on monorepo#3507; maintainer-only, not re-requested)
  • Cursor Bugbot: usage limit reached (measured 2026-09-22T20:53:35Z on monorepo#3507; maintainer-only, not re-requested)

What I checked:

  • Correctness: the change is YAML comments only. The parsed configuration (yq, keys sorted, JSON) hashes identically on main (1cf4577) and this head (80db48ea…93af), so Dependabot's behaviour cannot change.
  • Every factual claim in the comment against live state: desktop/go.mod has exactly two direct requirements (ksail/v7 via replace => ../, and wails/v3, which the root does not require), so every shared dependency is // indirect there; #7118 is a Dependabot security update "in /desktop"; the 📋 Apply patches step in ci.yaml restricts a Dependabot branch to desktop-tidy.patch (#6974); #7185 (2026-09-22) shows the resulting ksail-bot commit touching only desktop/go.mod and desktop/go.sum; #7140 is open and records the lost rebase ability.
  • #6816's acceptance criteria: criteria 1 and 2 are met under the current mechanism by grouped talos PR #6826 (a4971d2, sync commit dated 2026-09-19): desktop files updated, and desktop build job 105896103711 fails on MachineConfig.Kubelet, AllowCreateOnUpdate(context.Context) and CheckpointPod, not on go: updates to go.mod needed. The only remaining criterion is recording the mechanism and its reasoning in dependabot.yaml, which this PR does, so Fixes #6816 is justified.
  • Security: no workflow, trigger, permission or secret change; no executable surface.
  • Merge interplay: merges cleanly with main and with #7199 (both edit dependabot.yaml in separate hunks; git merge-tree clean, merged text coherent).
  • CI at this head: 53 check runs, all success or skipped; MegaLinter (yamllint, prettier) green.

Verdict: no P0/P1 findings


Generated by Claude Code

@devantler
devantler marked this pull request as ready for review September 23, 2026 05:07
@devantler
devantler merged commit 9715938 into main Sep 23, 2026
54 checks passed
@devantler
devantler deleted the claude/deps-record-desktop-module-mechanism-6816 branch September 23, 2026 05:07
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

fix(deps): grouped gomod updates skip the desktop module, so the talos group PR fails before reaching the real bump

2 participants