Skip to content

feat(ci)!: retire the unused lint workflow - #738

Merged
devantler merged 3 commits into
mainfrom
codex/retire-unused-lint-731-r68
Oct 24, 2026
Merged

devantler merged 3 commits into
mainfrom
codex/retire-unused-lint-731-r68

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

The last product now owns its whole-repository lint job, so the shared wrapper and its dedicated smoke fixtures no longer serve a production consumer. Keeping them adds maintenance work and obscures ownership.

What

Retire the unused interface and document the remaining catalogue consistently. Preserve the live Go validation, both signing assertions, credential isolation, scanner cases and manual-fix coverage.

Part of #731

💥 Breaking change: the legacy whole-repository Lint interface is removed from the next major release. Existing immutable release pins remain available.

⚠️ Merge order: verify current-main CI recovery under #735 before promotion; full native CI and protected review remain required.

Retain the live Go pipeline, both signing assertions, scanner and credential controls after the final production consumer migrated.

BREAKING CHANGE: the whole-repository lint workflow is no longer exported. Existing immutable pins remain available; consuming repositories own this single-product job.

Refs #731.
@github-code-quality

github-code-quality Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: Go, C#

Go / code-coverage/test

main 4ec0199 codex/retire-unused-... ce2d4d1 +/-
50% 50% 0%

C# / code-coverage/dotnet

main 4ec0199 codex/retire-unused-... ce2d4d1 +/-
100% 100% 0%

Go / code-coverage/go

main 4ec0199 codex/retire-unused-... ce2d4d1 +/-
50% 50% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated October 24, 2026 18:18 UTC

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@coderabbitai

coderabbitai Bot commented Oct 24, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 4ec0199 and ce2d4d1.

Files selected for processing: 25
  • .github/agent-guides/invariants.md
  • .github/agent-guides/workflows.md
  • .github/scripts/ci-selection/inventory.json
  • .github/tests/megalinter-clean-fixture/good.json
  • .github/tests/test-actionlint-arguments-lockstep.sh
  • .github/tests/test-catalogue-pin-guards-controls.sh
  • .github/tests/test-catalogue-tool-pin-parity.sh
  • .github/tests/test-ci-catalogue-scope.sh
  • .github/tests/test-ci-selection.sh
  • .github/tests/test-lint-credential-boundary.sh
  • .github/tests/test-lint-recovery-gates.sh
  • .github/tests/test-lint-signed-commit-shape-ablation.sh
  • .github/tests/test-lint-signed-commit.sh
  • .github/tests/test-lint-workflow-fixes.sh
  • .github/tests/test-megalinter-go-toolchain.sh
  • .github/tests/test-megalinter-root-config.sh
  • .github/tests/test-multi-trigger-input-gate-polarity-ablation.sh
  • .github/tests/test-multi-trigger-input-gate-polarity.sh
  • .github/tests/test-workflow-readme-parity.sh
  • .github/workflows/ci.yaml
  • .github/workflows/lint.yaml
  • .github/workflows/validate-go-project-readonly.yaml
  • .github/workflows/validate-go-project.yaml
  • .scripts/check-workflow-readme.sh
  • README.md
Files with no reviewable changes: 4
  • .github/tests/megalinter-clean-fixture/good.json
  • .github/scripts/ci-selection/inventory.json
  • .github/workflows/lint.yaml
  • README.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details
Additional context used
Code guidelines: 5
.github/agent-guides/workflows.md — auto-discovered
actions/CONTRIBUTING.md — auto-discovered
.github/agent-guides/invariants.md — auto-discovered
.github/governance-audits.md — auto-discovered
CONTRIBUTING.md — auto-discovered
Path-based instructions: 8
Applicability reference: AGENTS.md: # AGENTS.md — devantler-tech/.github (GitHub-as-code) | Guide | Read before | |---|---| | [Workflow and CI contracts](.github/agent-guides/workflows.md) | Any catalogue implementation, test or workflow ch...

CodeRabbit inference engine (.github/agent-guides/workflows.md)

Files:

  • .github/tests/test-lint-workflow-fixes.sh
  • .github/tests/test-ci-selection.sh
  • .github/tests/test-catalogue-tool-pin-parity.sh
  • .github/tests/test-multi-trigger-input-gate-polarity.sh
  • .github/tests/test-lint-signed-commit-shape-ablation.sh
  • .github/tests/test-ci-catalogue-scope.sh
  • .github/tests/test-workflow-readme-parity.sh
  • .github/tests/test-catalogue-pin-guards-controls.sh
  • .github/tests/test-megalinter-root-config.sh
  • .github/tests/test-multi-trigger-input-gate-polarity-ablation.sh
  • .github/tests/test-actionlint-arguments-lockstep.sh
  • .github/tests/test-lint-recovery-gates.sh
  • .github/tests/test-megalinter-go-toolchain.sh
  • .github/tests/test-lint-credential-boundary.sh
  • .github/tests/test-lint-signed-commit.sh
Applicability reference: AGENTS.md: # AGENTS.md — devantler-tech/.github (GitHub-as-code) Full detail in [actions/CONTRIBUTING.md](actions/CONTRIBUTING.md).

CodeRabbit inference engine (actions/CONTRIBUTING.md)

Files:

  • .github/tests/test-lint-workflow-fixes.sh
  • .github/tests/test-ci-selection.sh
  • .github/tests/test-catalogue-tool-pin-parity.sh
  • .github/tests/test-multi-trigger-input-gate-polarity.sh
  • .github/tests/test-lint-signed-commit-shape-ablation.sh
  • .github/tests/test-ci-catalogue-scope.sh
  • .github/tests/test-workflow-readme-parity.sh
  • .github/tests/test-catalogue-pin-guards-controls.sh
  • .github/tests/test-megalinter-root-config.sh
  • .github/tests/test-multi-trigger-input-gate-polarity-ablation.sh
  • .github/tests/test-actionlint-arguments-lockstep.sh
  • .github/tests/test-lint-recovery-gates.sh
  • .github/tests/test-megalinter-go-toolchain.sh
  • .github/tests/test-lint-credential-boundary.sh
  • .github/workflows/ci.yaml
  • .github/tests/test-lint-signed-commit.sh
Applicability reference: AGENTS.md: # AGENTS.md — devantler-tech/.github (GitHub-as-code) | Guide | Read before | |---|---| | [Tested invariants](.github/agent-guides/invariants.md) | Any catalogue implementation or test c...

CodeRabbit inference engine (.github/agent-guides/invariants.md)

Files:

  • .github/workflows/validate-go-project.yaml
  • .github/workflows/ci.yaml
Applicability reference: AGENTS.md: # AGENTS.md — devantler-tech/.github (GitHub-as-code) Full detail in [actions/CONTRIBUTING.md](actions/CONTRIBUTING.md).

CodeRabbit inference engine (actions/CONTRIBUTING.md)

Files:

  • .github/workflows/ci.yaml
Applicability reference: AGENTS.md: # AGENTS.md — devantler-tech/.github (GitHub-as-code) | Guide | Read before | |---|---| | [Workflow and CI contracts](.github/agent-guides/workflows.md) | Any catalogue implementation, t...

CodeRabbit inference engine (.github/agent-guides/workflows.md)

Files:

  • .github/workflows/ci.yaml
Applicability reference: AGENTS.md: # AGENTS.md — devantler-tech/.github (GitHub-as-code) Routine repository/admin-team monitoring is described in [`.github/governance-audits.md`](.github/governance-audits.md).

CodeRabbit inference engine (.github/governance-audits.md)

Files:

  • .github/tests/test-lint-workflow-fixes.sh
  • .github/tests/test-ci-selection.sh
  • .github/tests/test-catalogue-tool-pin-parity.sh
  • .github/workflows/validate-go-project.yaml
  • .github/agent-guides/workflows.md
  • .github/tests/test-multi-trigger-input-gate-polarity.sh
  • .github/workflows/validate-go-project-readonly.yaml
  • .github/tests/test-lint-signed-commit-shape-ablation.sh
  • .github/tests/test-ci-catalogue-scope.sh
  • .github/tests/test-workflow-readme-parity.sh
  • .github/tests/test-catalogue-pin-guards-controls.sh
  • .github/tests/test-megalinter-root-config.sh
  • .github/tests/test-multi-trigger-input-gate-polarity-ablation.sh
  • .github/tests/test-actionlint-arguments-lockstep.sh
  • .github/agent-guides/invariants.md
  • .github/tests/test-lint-recovery-gates.sh
  • .github/tests/test-megalinter-go-toolchain.sh
  • .github/tests/test-lint-credential-boundary.sh
  • .github/workflows/ci.yaml
  • .github/tests/test-lint-signed-commit.sh
Applicability reference: AGENTS.md: # AGENTS.md — devantler-tech/.github (GitHub-as-code) | Guide | Read before | |---|---| | [Tested invariants](.github/agent-guides/invariants.md) | Any catalogue implementation or test change | AGENTS.md:...

CodeRabbit inference engine (.github/agent-guides/invariants.md)

Files:

  • .github/tests/test-megalinter-go-toolchain.sh
Applicability reference: AGENTS.md: # AGENTS.md — devantler-tech/.github (GitHub-as-code) Three things share one repo: **The org's public profile** — `profile/README.md` (rendered on the org page), plus the org-wide community health files i...

CodeRabbit inference engine (CONTRIBUTING.md)

Files:

  • .github/tests/test-lint-workflow-fixes.sh
  • .github/tests/test-ci-selection.sh
  • .github/tests/test-catalogue-tool-pin-parity.sh
  • .github/workflows/validate-go-project.yaml
  • .github/agent-guides/workflows.md
  • .github/tests/test-multi-trigger-input-gate-polarity.sh
  • .github/workflows/validate-go-project-readonly.yaml
  • .github/tests/test-lint-signed-commit-shape-ablation.sh
  • .github/tests/test-ci-catalogue-scope.sh
  • .github/tests/test-workflow-readme-parity.sh
  • .github/tests/test-catalogue-pin-guards-controls.sh
  • .github/tests/test-megalinter-root-config.sh
  • .github/tests/test-multi-trigger-input-gate-polarity-ablation.sh
  • .github/tests/test-actionlint-arguments-lockstep.sh
  • .github/agent-guides/invariants.md
  • .github/tests/test-lint-recovery-gates.sh
  • .github/tests/test-megalinter-go-toolchain.sh
  • .github/tests/test-lint-credential-boundary.sh
  • .github/workflows/ci.yaml
  • .github/tests/test-lint-signed-commit.sh
LanguageTool
.github/agent-guides/workflows.md

[uncategorized] ~258-~258: The official name of this software platform is spelled with a capital “H”.
Context: ...anged path is under the repository-root .github/workflows/. Keep mixed edits and renam...

(GITHUB)

.github/agent-guides/invariants.md

[uncategorized] ~44-~44: The official name of this software platform is spelled with a capital “H”.
Context: ...ixes.yaml. ci.yamlasserts this with.github/tests/test-fixer-credential-boundary.sh...

(GITHUB)

Additional comments: 21
.github/workflows/ci.yaml: 1

5922-5922: LGTM!

Also applies to: 5989-5989, 6013-6014, 6053-6053

.github/tests/test-ci-catalogue-scope.sh: 1

210-211: LGTM!

.github/tests/test-ci-selection.sh: 1

82-84: LGTM!

.github/tests/test-actionlint-arguments-lockstep.sh: 1

10-10: LGTM!

Also applies to: 35-35, 70-70

.github/tests/test-catalogue-pin-guards-controls.sh: 1

70-70: LGTM!

Also applies to: 106-106

.github/tests/test-catalogue-tool-pin-parity.sh: 1

7-7: LGTM!

Also applies to: 58-58, 63-63

.github/tests/test-lint-credential-boundary.sh: 1

5-5: LGTM!

Also applies to: 14-14, 21-21, 23-23, 27-30, 34-36, 58-58, 71-71

.github/tests/test-lint-recovery-gates.sh: 1

8-8: LGTM!

Also applies to: 146-147, 294-294

.github/tests/test-lint-signed-commit-shape-ablation.sh: 1

45-47: LGTM!

.github/tests/test-lint-signed-commit.sh: 1

19-19: LGTM!

Also applies to: 253-254, 259-259

.github/tests/test-lint-workflow-fixes.sh: 1

15-15: LGTM!

.github/tests/test-megalinter-go-toolchain.sh: 1

10-10: LGTM!

Also applies to: 14-15, 17-17, 19-19, 44-48

.github/tests/test-megalinter-root-config.sh: 1

8-8: LGTM!

Also applies to: 11-11, 13-13, 24-24

.github/tests/test-multi-trigger-input-gate-polarity-ablation.sh: 1

14-14: LGTM!

Also applies to: 79-79, 83-86, 94-94

.github/tests/test-multi-trigger-input-gate-polarity.sh: 1

15-17: LGTM!

.github/agent-guides/invariants.md: 1

28-28: LGTM!

Also applies to: 30-30, 44-44

.github/agent-guides/workflows.md: 1

256-256: LGTM!

Also applies to: 260-260

.github/tests/test-workflow-readme-parity.sh: 1

60-60: LGTM!

Also applies to: 235-235

.github/workflows/validate-go-project-readonly.yaml: 1

811-812: LGTM!

Also applies to: 830-830

.github/workflows/validate-go-project.yaml: 1

880-881: LGTM!

Also applies to: 900-900

.scripts/check-workflow-readme.sh: 1

12-12: LGTM!

Also applies to: 21-21

Walkthrough

The pull request deletes the reusable whole-repository lint workflow and removes its CI test jobs and required-check entries. It updates workflow tests and catalogue guards to check Production Go and its read-only projection. It also updates credential-boundary checks, retired-workflow detection, and documentation.

Possibly related issues

Possibly related PRs

  • devantler-tech/.github#724 — Defines catalogue indexes and documents lint as a compatibility source; this pull request removes that interface and updates related documentation and parity checks.

Priority: Low

Merge Risk: Minimal · up to ce2d4

The lint export retirement appears mergeable after the stated CI and protected-review checks. No actionable issue is established by the supplied changes.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 54.55% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 16 files. (5 skipped:… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly identifies the main change: retiring the unused Lint workflow. It is concise and specific.
Description check Passed The description explains why the workflow is retired, what changes, the preserved controls, and the breaking-change impact. It is directly related to the changeset.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 54.55% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 16 files. (5 skipped: 5 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Blocker: #735 | upstream | last-verified 2026-10-24: Recovery issue remains open; main CI 40113569754 attempt 2 failed. Keep draft at ce2d4d1 until recovery is demonstrated. The current-head docstring coverage warning also remains unresolved.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Readiness at ce2d4d19b3e3e05311dda3dbc172d8cc2290e2dc: #735 is resolved with successful real main CI 40131510110. The last product migration, World #1494, is merged as 129676fe0aacee469519fbf2b9ce2ecba82f3898. A fresh, complete default-branch workflow census found no production caller of the retired lint export or the deleted legacy repositories.

Full native CI 40119411502 passes at this exact head, including catalogue parity and retained production scanner controls. CodeRabbit completed a full review of this commit with no actionable findings; complete thread and formal-review reads are clear. I opened the rendered README at this commit, expanded both matching Reference/Purpose/Source indexes and one workflow reference, and verified the independent collapsibles work. The export being removed has no remaining consumer runtime to exercise; retained behavior is covered by the native controls. The breaking release, signed publication and final source/reconciliation audit remain tracked on #731 after this source merge.

@devantler
devantler marked this pull request as ready for review October 24, 2026 21:09
@devantler
devantler merged commit c2d20c8 into main Oct 24, 2026
268 checks passed
@devantler
devantler deleted the codex/retire-unused-lint-731-r68 branch October 24, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant