Skip to content

fix(ci): accept publisher releases with unchanged approved contents - #725

Merged
devantler merged 3 commits into
mainfrom
dependabot/github_actions/devantler-tech/dot-github/dot-github/workflows/publish-manifests.yaml-12.0.1
Oct 23, 2026
Merged

devantler merged 3 commits into
mainfrom
dependabot/github_actions/devantler-tech/dot-github/dot-github/workflows/publish-manifests.yaml-12.0.1

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

Routine publisher updates are blocked because a safety test requires an older release, even when the publishing behavior is unchanged.

What

Update the publisher and accept new releases only when their publishing contents remain approved. Preserve publication safeguards and reject changed or unverifiable publishers.

Fixes #727

…nifests.yaml

Bumps [devantler-tech/.github/.github/workflows/publish-manifests.yaml](https://github.com/devantler-tech/.github) from 10.0.3 to 12.0.1.
- [Release notes](https://github.com/devantler-tech/.github/releases)
- [Commits](0f39032...6f1dee9)

---
updated-dependencies:
- dependency-name: devantler-tech/.github/.github/workflows/publish-manifests.yaml
  dependency-version: 12.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@botantler-1
botantler-1 Bot enabled auto-merge (squash) October 23, 2026 08:15
@github-code-quality

github-code-quality Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: Go

Go / code-coverage/test

main 93a7889 dependabot/github_ac... 33a511f +/-
50% 50% 0%

Go / code-coverage/go

main 93a7889 dependabot/github_ac... 33a511f +/-
50% 50% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated October 23, 2026 10:33 UTC

Signed-off-by: Nikolai Emil Damm <nikolaiemildamm@icloud.com>
@devantler
devantler marked this pull request as draft October 23, 2026 10:25
auto-merge was automatically disabled October 23, 2026 10:25

Pull request was converted to draft

@devantler devantler changed the title chore(deps): bump devantler-tech/.github/.github/workflows/publish-manifests.yaml from 10.0.3 to 12.0.1 fix(ci): accept publisher releases with unchanged approved contents Oct 23, 2026
@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Publisher update review, v10.0.3 → v12.0.1: read every release note in the range (v10.0.4, v10.0.5, v10.1.0, v10.2.0, v10.2.1, v11.0.0, v12.0.0, v12.0.1), the current catalogue/publication guides, and the full source comparison. The separate actions changelog is historical; no additional current migration guide is published.

The eight announced changes are: configuration publishing through the approved publisher (already adopted); singleton admission retirement (already adopted); recovery publisher command and default-off recovery workflow (repository-owned and already adopted); Go-cache observer recovery (not used by this manifests-only call); retirement of the catalogue-only .NET workflow (not used by this call); repository ownership of release recovery (already adopted, no removed export is called); and withdrawal of legacy Actions management (already adopted). No new publisher workaround or capability adoption is needed. The two major removals do not affect the selected manifests interface.

The complete publisher workflow and both scripts it copies have identical Git blobs and regular-file modes at the old and new publisher commits: workflow ce9a9897b154486218478734a02c61e5ac3ea479, absence helper 3566e4067e953a1d9cb34e6a50a0f9b72a5d8bc8, recovery helper 48dc38f60ddebf90b0976758df9f1983bbb86bfd. The caller verifier and signed-promotion opt-ins remain enabled. The deployed approved-revision check remains an independent publication gate.

Issue #727 repair: the updated caller reproducibly failed the old test; the repaired promotion suite passes with the original signing, failure-ordering, immutable-version and recovery controls intact. The real new guard also accepts unchanged releases from a shallow consumer, refuses changed workflow/helper contents and modes, and refuses malformed references or missing publication controls. Repository baseline validation and all eight other local publication safety suites pass; native registry/cryptographic hosted proof remains to be collected at the pushed head. Correctness, simplification and security self-review found no unresolved findings.

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review skipped.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown

Important

Review skipped

This PR was authored by a bot without an assigned CodeRabbit review seat. Ask an organization administrator to assign a seat to the bot. See the seat-assignment guide. After the seat is assigned, request a review again.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: devantler-tech/.github
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: 93a7889
  • Layers: Repository YAML (base), Organization UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 1d1848d0-aa0c-41fd-b3f5-df956d0754cb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

CodeRabbit declined this request because the bot author has no assigned review seat. The complete current-head artifact guard reports ADMIT: no substantive review or finding was published. The required CI and product admission passed at this head; review proceeds to Codex. The PR stays draft while semantic review and native scanner ingestion remain pending.

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T10:59:23.879885Z 33a511f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 33a511f4a8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Readiness at 33a511f4a847e09b2285323973778b5e205898b8: latest CI 39939182427 and all readable required gates pass, with zero unresolved threads or non-thread findings and a current-head Codex clean review (6363345332). The configured code-quality rule has no readable head verdict; GitHub reports CLEAN.

User evaluation: I inspected native job 120366680796 at this exact head. It exercises the actual updated caller, accepts unchanged publisher releases, rejects changed workflow/helper bytes and modes, and preserves signed-claim, digest, late-version and partial-publication refusals against disposable cryptographic/registry fixtures. All those assertions pass. This is the exercisable publishing contract; no production publication is claimed.

The scanner-only recovery of job 120365769783 completed as run 39939048059 attempt 2 at the unchanged head. Native analysis 2012970773 has no processing error, and the zizmor check now succeeds with no new alerts. The earlier completed-neutral result was insufficient and did not authorize promotion.

The published body passes the repository template contract. Source activity is outside the ownership window and the local holder check reports none. The PR is ready for promotion; rebind readiness again before protected merge.

@devantler
devantler marked this pull request as ready for review October 23, 2026 12:32
@devantler
devantler merged commit 602159b into main Oct 23, 2026
341 of 512 checks passed
@devantler
devantler deleted the dependabot/github_actions/devantler-tech/dot-github/dot-github/workflows/publish-manifests.yaml-12.0.1 branch October 23, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Promotion caller test rejects tracked publisher pin updates

1 participant