Skip to content

fix(ci)!: keep release recovery repository-owned - #723

Merged
devantler merged 2 commits into
mainfrom
codex/local-recovery-722-r47
Oct 22, 2026
Merged

devantler merged 2 commits into
mainfrom
codex/local-recovery-722-r47

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

Release recovery is advertised as shared automation even though no product uses it. That makes the catalogue harder to navigate and encourages centralizing a procedure before there is a real need.

What

Keep recovery as this repository's manual operation, preserving confirmation and credential safeguards. Separate its internal offline validation from supported consumer interfaces and update the ownership guidance and usage documentation.

Fixes #722

💥 Breaking change: the unused reusable recovery interface becomes manual-only; a future product must own its recovery procedure until repeated use justifies extraction.

Comment thread .github/workflows/ci.yaml Fixed
Comment thread .github/workflows/ci.yaml Fixed
@github-code-quality

github-code-quality Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: Go, C#

Go / code-coverage/test

main 8723698 codex/local-recovery... e0b656f +/-
50% 50% 0%

C# / code-coverage/dotnet

main 8723698 codex/local-recovery... e0b656f +/-
100% 100% 0%

Go / code-coverage/go

main 8723698 codex/local-recovery... e0b656f +/-
50% 50% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated October 22, 2026 20:55 UTC

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Fixed the two same-repository security findings at signed head e0b656f2492d4a0d0c41c3978e3ce915cb659dc0.

Both internal offline-fixture calls now use native $/ references, binding them to the defining workflow's repository and exact commit without relying on workspace lookup. The required coverage guard now reads parsed job-level call values and compares exact classic/native references; a comment, display name, step-level reference or similar filename cannot stand in for execution.

The new native-call control failed against the original guard. Both real call forms and all non-call controls now pass, along with the complete existing wiring suite, recovery authority/projection controls, documentation/layout checks, shellcheck and the full reached credential graph with all 44 real-source refusal controls. No scanner or required check was disabled. Fresh native CI and a substantive current-head review remain required.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 34 minutes.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 34 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 8723698 and e0b656f.

📒 Files selected for processing: 9
  • .github/agent-guides/catalogue.md
  • .github/agent-guides/workflows.md
  • .github/scripts/generate-release-recovery-fixture.sh
  • .github/tests/test-publish-release-recovery.sh
  • .github/tests/test-test-script-wiring.sh
  • .github/workflows/ci.yaml
  • .github/workflows/publish-release-recovery.yaml
  • .github/workflows/release-recovery-offline-fixture.yaml
  • README.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Review availability for unchanged green head e0b656f2492d4a0d0c41c3978e3ce915cb659dc0:

CodeRabbit's authenticated request received refusal 6352139427 at 21:53:25 UTC, stating that its included review is unavailable for 34 minutes. This PR-scoped refusal is not a review; no usage-based billing is authorized. A complete current-head no-gate scan confirms no delivered CodeRabbit verdict or finding is being discarded. The ordered loop therefore advances to Codex, with full native CI, the published body and both addressed native-security threads already clear. A substantive exact-head review is still required.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T22:01:27.094354Z e0b656f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: e0b656f249

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Ready at signed head e0b656f2492d4a0d0c41c3978e3ce915cb659dc0: full native CI is green, native merge state is CLEAN, and Codex receipt 6352268320 reviewed e0b656f249 with no findings. The complete review scan finds no accompanying non-thread finding; all review threads are resolved. The published body passes the effective repository template.

The former unused shared recovery entry is now repository-owned and manual; its internal offline fixture has no publishing job or secrets. Independent projection, generator equality, refusal, credential-boundary and actual native-call controls pass. Existing admission, least privilege, default-off consent and build-before-credentials controls remain intact. Self-review, simplification and security passes found no outstanding issue. Promotion does not authorize a production recovery run, retire #603 or complete legacy Actions deletion under #240.

@devantler
devantler marked this pull request as ready for review October 22, 2026 22:05
@devantler
devantler merged commit ab94cee into main Oct 22, 2026
280 checks passed
@devantler
devantler deleted the codex/local-recovery-722-r47 branch October 22, 2026 22:06
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Delivered #722 through protected merge and normal publication.

  • Reviewed head: e0b656f2492d4a0d0c41c3978e3ce915cb659dc0; signed squash: ab94cee100a695a8ca69e29ec0e7a80a2d49ad7d. Full native CI, Codex review 6352268320, the complete finding/thread sweep and the effective PR template passed before merge.
  • Normal Release published v12.0.0. Post-merge CI and signed config publication succeeded at that exact squash source.
  • Published artifact: ghcr.io/devantler-tech/github-config/manifests@sha256:87ca6fb93e8aa7b31c177b49d7e79be8a077b7823336b7993f20e429c45a0a4b. Independent anonymous readback verified the exact digest signature against the maintained publisher at 0f390329b590404c02565b27a263ee841fa02bce, GitHub issuer, caller repository, release tag and full source, plus the normal publication run/attempt bindings.

The unused public recovery export is gone. Recovery is repository-owned and manual; the internal offline fixture has no publisher or secrets. No production recovery was activated, #603 remains a separate rollout gate, and legacy Actions deletion remains open under #240.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep unadopted release recovery repository-owned

2 participants