Repository navigation
feat(ci): switch on the world-at-ruin deploy-starter policy for its trial - #623
Merged
Merged
Conversation
…rial Part of #202 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
14 tasks
Code coverage overviewLanguages: Go, C# Go / code-coverage/test
C# / code-coverage/dotnet
Go / code-coverage/go
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
Contributor
Author
@coderabbitai full review |
✅ Action performedFull review finished. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely describes enabling the world-at-ruin deploy-starter policy for its trial. |
| Description check | |
The description directly explains the policy change, its scope, validation evidence, rollout plan, and exclusion of server-cd.yaml. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Contributor
Author
Blocker: switch on the world-at-ruin deploy-starter policy: promote this pull request (that is the approval), or say no on it | authority | last-verified 2026-10-17: CodeRabbit full review at 6df50bc found nothing actionable, CI green; per scripts/validate-workflow-execution-policies.sh adding a policy to approved_active is the maintainer's approval | asked pr 2026-10-17 |
Contributor
Author
@coderabbitai full review |
✅ Action performedFull review finished. |
Contributor
Author
Readiness at 787bbdd — the maintainer approved this activation (option A) in the week 43 digest; ask monorepo#4315.
Unparking and promoting; after merge I will check that the policy-apply run on |
Contributor
Author
Post-merge verification: the Apply workflow execution policies run on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Data Product Controller trial of the deploy-starter policy passed, and its outcome is recorded on #202:
The rollout plan in #202 activates one repository at a time. Until more policies are on, anyone with write access can still start the other repositories' deploy workflows by hand.
What
Switches on the same policy for world-at-ruin, so only the three portfolio identities may start its
cd.yaml.scripts/workflow-execution-actors.shexited 0 with no UNKNOWN row.cd.yamlran on 83 tag pushes, started only bydevantlerandbotantler-1[bot], and both are on the allowlist.server-cd.yaml, a second deploy workflow in world-at-ruin, is outside this policy's targeting. Covering it is a separate change, noted on Adopt workflow execution protections across the portfolio #202.Validation:
bash tests/workflow-execution-policies.shpasses, andscripts/validate-workflow-execution-policies.shreports OK for every file.Part of #202
👉 After merge/promotion: this pull request stays a draft because switching a policy on is the maintainer's decision. Marking it ready and merging it is that approval. The apply workflow then turns the policy on, and rollback is reverting this pull request. The trial runs for a week, and its outcome is recorded on #202.