Skip to content

Enable Code Quality before enforcing its org-wide merge gate #168

Closed as not planned

Description

@devantler

🤖 Generated by the Agentic Engineer

Problem

The active organization ruleset Require code quality results (16885082) targets every default branch at severity all, but at least one targeted repository does not produce the required GitHub Code Quality result.

Live reproduction: wedding-app#277 at signed head bcdd7bb6c684d3c58ba255b10cf9dcbdcf1d6476 has green required CI, E2E, build, boot smoke, Lighthouse, dependency review, CodeQL, workflow security, and current-head CodeRabbit review; GitHub reports mergeable=MERGEABLE but mergeStateStatus=BLOCKED. No CodeQL - Code Quality check/result exists. The repository's ordinary CodeQL default setup is configured, which is a separate surface and does not establish that GitHub Code Quality is enabled.

GitHub's rollout procedure says to confirm the CodeQL - Code Quality check ran successfully before activating this threshold: https://docs.github.com/en/code-security/how-tos/maintain-quality-code/set-pr-thresholds

The organization-admin bypass exists, but using it here would hide the missing deployment fact and make the active quality rule decorative for automation.

Acceptance

  • Determine live GitHub Code Quality enablement for every repository targeted by ruleset 16885082; preserve unresolved repositories as unknown.
  • Either enable Code Quality on the intended targets after its activation/billing facts are settled, or narrow/evaluate the rule so it does not actively block repositories that cannot emit a result.
  • On a representative affected PR, observe a successful CodeQL - Code Quality result and mergeStateStatus=CLEAN without an admin bypass.
  • Unblock wedding-app#277 and complete actions#997's live signed-template-sync verification.
  • Keep declarative adoption tracked by parent Adopt supported GitHub rulesets and track remaining provider gaps #69 while provider support for rule type code_quality remains absent.

Part of #69.

Activity

  1. added theissue type on Aug 22, 2026
  2. moved this to 📥 Backlog in 🌊 Project Boardon Aug 22, 2026
  3. devantler commented on Aug 22, 2026

    @devantler
    ContributorAuthor

    🤖 Generated by the Agentic Engineer

    Correction: the blocker diagnosis in this issue was false.

    At the same exact wedding-app#277 head (bcdd7bb6c684d3c58ba255b10cf9dcbdcf1d6476), the actual blocker was one unresolved CodeRabbit review thread. I reproduced the concern against the reusable workflow's old and new pins, posted the evidence, and resolved that thread. The PR immediately changed from BLOCKED to CLEAN without enabling Code Quality and without using the organization-admin bypass.

    The PR then merged normally as 142ef4c941cc8756009a6e1b4f13c41d08975076, and live workflow run 32582333703 completed successfully. Its generated commit f5d1b8261d4431fd61da2e50088cbd2803f8d383 is API-verified.

    No Code Quality activation was required for this delivery. Closing this agent-created issue as an invalid diagnosis.

  4. moved this from 📥 Backlog to ✅ Done in 🌊 Project Boardon Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Priority

    None yet

    Effort

    None yet

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions