Skip to content

test: rename SHIPNODE_ENV_FILE → SHIPNODE_DEPLOY_SECRET_FILE (onpair e2e) - #14

Open
devalade wants to merge 3 commits into
v3from
test/onpair-drift-env-var
Open

test: rename SHIPNODE_ENV_FILE → SHIPNODE_DEPLOY_SECRET_FILE (onpair e2e)#14
devalade wants to merge 3 commits into
v3from
test/onpair-drift-env-var

Conversation

@devalade

@devalade devalade commented Aug 11, 2026

Copy link
Copy Markdown
Owner

Drift test for OnPair: source-only env var rename, docs intentionally untouched.

Summary by CodeRabbit

  • Bug Fixes
    • Updated generated GitHub Actions workflows to use the correct deployment secret file setting when validating and creating environment configuration files.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d3d88b45-af2a-4b94-acbc-4706f006b5fe

📥 Commits

Reviewing files that changed from the base of the PR and between fe33d81 and 9d5f14f.

📒 Files selected for processing (1)
  • src/cli/commands/ci.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/cli/commands/ci.ts

📝 Walkthrough

Walkthrough

The generated GitHub Actions workflow now uses SHIPNODE_BUILD_SECRET_FILE for the environment secret. Validation, permissions, directory creation, and dotenv file output remain unchanged.

Changes

CI workflow secret handling

Layer / File(s) Summary
CI secret variable update
src/cli/commands/ci.ts
The workflow replaces SHIPNODE_ENV_FILE with SHIPNODE_BUILD_SECRET_FILE when it validates and writes the secret file.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies the environment-variable rename in the OnPair end-to-end test, but its target name differs from the SHIPNODE_BUILD_SECRET_FILE change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/onpair-drift-env-var

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/cli/commands/ci.ts`:
- Around line 207-212: Update the generated-workflow assertions in the relevant
test case to expect SHIPNODE_DEPLOY_SECRET_FILE and $SHIPNODE_DEPLOY_SECRET_FILE
instead of the renamed SHIPNODE_ENV_FILE variable, while preserving the existing
workflow-content checks.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fd370fd0-61cd-43ce-ae16-1a4167ecc160

📥 Commits

Reviewing files that changed from the base of the PR and between a06551f and 755ede1.

📒 Files selected for processing (1)
  • src/cli/commands/ci.ts

Comment thread src/cli/commands/ci.ts Outdated
@devalade devalade closed this Aug 11, 2026
@devalade devalade reopened this Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant