Repository navigation
fix(ci): use PlatformClaw approvers for dependency and security changes - #427
Merged
Merged
Conversation
devSejung
marked this pull request as ready for review
October 31, 2026 13:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Fixes an issue where PlatformClaw inherited explicit approval authority for upstream OpenClaw accounts while its own maintainer iililiiilili could not authorize dependency or security-sensitive changes with a repository write role. Related: #426.
Why This Change Was Made
The repository owner explicitly delegated both guard approvals to iililiiilili and requested removal of upstream approvers. Replace vincentkoc, steipete, and joshavant with iililiiilili in all five workflow approval lists (three Dependency Guard steps and two Security Sensitive Guard steps). Update the two existing workflow assertions.
User Impact
After this reaches main, iililiiilili can authorize changes with
/allow-dependencies-changeand/allow-security-sensitive-change. Existing trusted-author handling also applies to this account. The repository owner remains authorized through the existing repository-admin check. No GitHub repository role is changed.Upstream accounts no longer receive authority merely from their usernames. The existing team lookup is scoped to the current repository owner, not the OpenClaw organization. Current-head authorization, trusted-base script execution, and existing CODEOWNERS remain intact. Existing same-head recorded approvals are not retroactively revoked. Automatic comment-triggered reruns and inherited bot wording are outside this change.
Evidence
git diff --checkand staged whitespace checks passed. Python/PyYAML parsed both workflows and verified all five lists contain only iililiiilili, with matching test assertions and no upstream account names in either workflow.createGuardApproverCheckshelper, invoked with synthetic GitHub API responses: explicit account accepted, the three upstream accounts denied without a current repository role, and repository-admin authority retained. The first ad hoc probe had an overly broad fixture URL matcher; correcting that fixture to match the collaborator path made the probe pass. This is supplementary function-level proof, not live authorization or a Vitest pass.autoreview --mode uncommitted --base 65910160dbfa268542b0e760855fab61d9ced3af --engine codex --max-priority P2(GPT-6.1 Sol): scoped-clean. Initial INDEX-only finding was resolved by staging the final candidate, followed by a clean full-candidate review. Published head: 37ec7b4.@vitest/utils; Docker Desktop Linux engine is unavailable. No local Vitest or Linux pass is claimed; hosted CI is required. Earlier-head CI is not current-head evidence.AI-assisted with Codex.