Skip to content

fix: separate session-store retirement owners and blockers - #384

Merged
devSejung merged 2 commits into
mainfrom
fix/session-store-compat-retirement
Oct 24, 2026
Merged

devSejung merged 2 commits into
mainfrom
fix/session-store-compat-retirement

Conversation

@devSejung

@devSejung devSejung commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

Closes #383
Related: #290

What Problem This Solves

Resolves a problem where compatibility reviewers see four beta.5 plugin SDK helpers and two package-root doctor aliases grouped under one SDK owner, despite their different removal conditions. Plain package-root helper labels also omit those aliases from the report's existing token-based reference search.

Why This Change Was Made

Split SDK and core retirement records at their existing source-owned boundaries. Both retain the original October 12 review date, verified published-reader migration, and explicit breaking-release approval. SDK removal additionally requires exclusion of beta.5 from the supported plugin floor; package-root removal requires the v2026.7.x legacy doctor upgrade window to close. Runtime exports, support floors, and failure predicates are unchanged.

This branch is refreshed onto main 59d800dd70b7924810467b440f367bf28dfb423b. Main #376 already fixed the original conditional-record classification and Zod security failure. The remaining diff is the owner/blocker split and report coverage; no dependency or security-guard change is added here.

User Impact

Maintainers can review the two retirement tasks independently, with visible dates, blockers, and heuristic references. References remain triage evidence, not proof that published plugin consumers have migrated. Genuine unconditional expirations still fail CI.

Evidence

  • Old head 897f5b120cf323e6142f118b27347c572ce97ef2 failed security-fast on GHSA-mrhx-c7xc-m3w5. The refreshed source inherits main's reviewed remediation; the exact command node scripts/pre-commit/pnpm-audit-prod.mjs --audit-level=high passed live on Ubuntu 22.04.5 / Node 24.18.0 / pnpm 11.15.1 at UTC 2026-10-24 11:41:24.
  • Focused Linux proof: 102 tests passed across registry, full/summary report date boundaries, unconditional fixtures, SDK/root exports, and production-audit artifact guards; canonical runner exit 0.
  • All 29 commands from the canonical five-file changed-check plan passed: 13 guard commands, one Knip command covering 3 scans, and the remaining 15 commands including all three tsgo lanes, lint, storage/import-cycle/auth guards. The full wrapper initially stopped on a corrupted task-local dlx artifact; its nonzero exit is retained, then the exact remaining plan was completed without skip flags. Targeted lint of the changed root report test also passed with zero warnings/errors. Real-date strict compatibility report: eligible=0, pending=26, due=25.
  • Canonical fresh P0–P2 autoreview: whole five-file candidate clean, then the final formatter-only assertion delta clean. Emitted JavaScript is identical across that formatting delta.
  • Production LOC: +24/-8 (net +16), justified by independent SDK/core public-contract ownership. Tests: +132/-71 (net +61). Docs: +30/-23 (net +7).
  • Final head 56e4d440cb48e09c5d361b652a37c88d10873699; Linux checked tree 0c2c8efea4f4de21b9df5cb3e6e6c34d7d876152 matches the committed tree. Exact-head CI completed successfully: 54 jobs passed, 13 intentionally skipped, zero failures. The original failing security-fast job, lint, and openclaw/ci-gate all passed.

@devSejung
devSejung marked this pull request as ready for review October 23, 2026 21:33
@devSejung
devSejung force-pushed the fix/session-store-compat-retirement branch from 897f5b1 to 56e4d44 Compare October 24, 2026 12:09
@devSejung devSejung changed the title fix: respect session-store retirement conditions in API checks fix: separate session-store retirement owners and blockers Oct 24, 2026
@devSejung
devSejung merged commit 1a01f72 into main Oct 24, 2026
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: conditional session-store retirement blocks the strict API check after October 12

1 participant