Repository navigation
test: build and drive a React 18 app in CI - #731
Merged
Merged
Conversation
…t/react-18-fixture
…t/react-18-fixture
Refs #691 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Contributor
Changepacks@devup-ui/wasm@1.0.83 → 1.0.84 - bindings/devup-ui-wasm/package.jsonPatch
@devup-ui/bun-plugin@1.0.22 → 1.0.23 - packages/bun-plugin/package.jsonPatch
@devup-ui/components@0.1.60 → 0.1.61 - packages/components/package.jsonPatch
@devup-ui/eslint-plugin@1.0.22 → 1.0.23 - packages/eslint-plugin/package.jsonPatch
@devup-ui/next-plugin@1.0.90 → 1.0.91 - packages/next-plugin/package.jsonPatch
@devup-ui/plugin-utils@1.0.17 → 1.0.18 - packages/plugin-utils/package.jsonPatch
@devup-ui/react@1.0.44 → 1.0.45 - packages/react/package.jsonPatch
@devup-ui/reset-css@1.0.31 → 1.0.32 - packages/reset-css/package.jsonPatch
@devup-ui/rsbuild-plugin@1.0.67 → 1.0.68 - packages/rsbuild-plugin/package.jsonPatch
@devup-ui/vite-plugin@1.0.73 → 1.0.74 - packages/vite-plugin/package.jsonPatch
@devup-ui/webpack-plugin@1.0.71 → 1.0.72 - packages/webpack-plugin/package.jsonPatch
|
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This was referenced Oct 3, 2026
Resolve .github/workflows/publish.yml by retaining both React 18 and main vinext/RSC CSS acceptance jobs as independent siblings. Keep every main job and step byte-equivalent after YAML parsing, preserve #700 published versions with React peer/dev dependency intent, and regenerate lockfile workspace metadata through bun install. Refs #691, #683 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
owjs3901
added a commit
that referenced
this pull request
Oct 6, 2026
Merge #731 head 5644a8a containing main a935315. Resolve .github/workflows/publish.yml by keeping the complete main vinext job and publish validation comment, extending every action SHA/toolchain/cache pin plus timeout30/read-only permissions to vinext. Keep React18 and both CSS modes, original release/deploy needs, #700 published versions and the clean-pkg build script. Refs #683 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
owjs3901
added a commit
that referenced
this pull request
Oct 8, 2026
Refs #691 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Preserve every inherited validation job and the React 18 browser gate. Refs #691 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #691 (M 네 번째 PR, React 18 fixture CI).
main에서 분기해 #720, #721, #722를 병합한 브랜치입니다. 세 PR이 먼저 병합되어야 합니다. 병합 후에는 이 PR의 차이가apps/react-18,publish.yml,bun.lock만 남습니다.요약
React 18.3.1 앱(
apps/react-18)을 Vite 플러그인과 UI kit으로 빌드한 다음, 실제 Chromium에서 동작을 확인하는 CI jobreact-18을 추가합니다. 패키지는 React^18 || ^19를 peer로 받으므로, React 19 전용 API가 다시 들어오면 이 job이 실패합니다.확인하는 것
React.version이18.로 시작styled('input')(생성 컴포넌트, fix(extractor): forward refs from generated styled components #722)의 ref가 실제 DOM 요소를 가리킴onChange호출 (컨텍스트, 이벤트, 위치 계산)tsc(React 18 타입)와vite build통과이 fixture로 찾은 버그
<Context value>로 컨텍스트를 제공해, React 18에서 렌더링하자마자 앱이 깨졌습니다(r is not a function). 수정은 #720에 커밋했습니다(d6453d82).구성
resolve.dedupe와 tsconfigpaths로 앱의 React 18 한 벌만 쓰게 하는데, 실제 설치 환경에서 peer가 앱의 React로 풀리는 것과 같습니다.새로 생기는 오류
검증
tsc통과,vite build통과,playwright test1개 통과W40 main 반영 (2026-10-06)
a935315c34b45aeda6dc156e29a5c76df51b76bd까지 병합했습니다 (병합 head:5644a8a6af6d3fd3dce26d054da828b845297cec).2026-10-08 main 11790bef를 병합하여 업데이트했습니다. 충돌 없이 갱신된 부모 PR의 변경과 main의 변경을 모두 보존했습니다.
2026-10-15 업데이트: main 76b1a15059d3d1b26c8ac20bb622a36cc937a7a4를 포함한 갱신된 #722 635acea8과 기본 스택 overflow의 root fix 5ef8d416f348a3f1ed6008e0e48a91d346db9eff를 두 부모 merge commit으로 병합했습니다; #720 820e7c19와 #721 583b735d는 이미 조상이어서 중복 병합하지 않았고 충돌 파일 없음, 부모의 bounded/name-preserving capture binder를 그대로 유지했습니다; publish.yml은 기존 #731과 byte-identical이며 main의 모든 job/step과 react-18 job을 보존했고 새 snapshot 변경 없음·추가 build error 없음; DEFAULT stack Rust 3232개/fmt/clippy·fresh WASM/root·Bun 5907개/0 fail/100%·React18 타입 검사/production build/원래 Chromium 시나리오 및 CI-unset 전체 훅 통과(Windows Rust 97.83%, whole-job peak 4.510 GB), 부모 CI38641638859 SUCCESS 확인 후 갱신했습니다.
2026-10-16 갱신: main
a6ecc125를 포함하고 CI38776560990이 성공한 갱신 #72250c98563d5e9082490b1efebf0ebf18ea3f4661a를 실제 두 부모 merge commit027208b95e7ff18d2b2f3ed7fb9938e88d5f0325로 병합했습니다(기존 #731a8fcf4f2+ 갱신 #72250c98563). 현재 #720820e7c19와 #721583b735d는 이미 조상이므로 중복 병합하지 않았습니다. Rust/WASM은 갱신 부모와 바이트 동일하고, main·기존 PR·부모의 모든 CI 5개 job/87개 step을 구조적으로 완전 비교해 보존했습니다. 기본 stack/jobs2/6GB 감시에서 Rust 4,110개·fmt/clippy, fresh WASM/root, Bun 5,911/0/함수·행 100%/lint, React18 앱 TS7/production build 및 원래 Chromium 6 refs/select/stepper/zero-errors 검사가 통과했습니다. 독립 gate APPROVE와 정상 전체 hook도 통과했으며(12GB cap/실제 peak 4.878GB, Windows Rust 97.99% 18,367/18,744은 Linux와 별도), preview/browser는 전부 종료했습니다. 추가 build error/runtime/dependency/snapshot 후보는 없고, 현재 head CI38856703766확인 중입니다.현재 head
027208b95e7ff18d2b2f3ed7fb9938e88d5f0325의 CI 38856703766가 전체 SUCCESS입니다. React18을 포함한 5개 job이 모두 통과했고 Linux Rust 100% (13,134/13,134), Bun 5,911 pass / 0 fail 및 함수·행 100%, preload regression 8 pass / 0 fail을 확인했습니다.