Repository navigation
fix(extractor): keep type-only imports type-only and read keyframes getName() - #709
Merged
Merged
Conversation
…etName() Refs #689 Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Contributor
Changepacks@devup-ui/wasm@1.0.83 → 1.0.84 - bindings/devup-ui-wasm/package.jsonPatch
@devup-ui/bun-plugin@1.0.22 → 1.0.23 - packages/bun-plugin/package.jsonPatch
@devup-ui/components@0.1.60 → 0.1.61 - packages/components/package.jsonPatch
@devup-ui/eslint-plugin@1.0.22 → 1.0.23 - packages/eslint-plugin/package.jsonPatch
@devup-ui/next-plugin@1.0.90 → 1.0.91 - packages/next-plugin/package.jsonPatch
@devup-ui/plugin-utils@1.0.17 → 1.0.18 - packages/plugin-utils/package.jsonPatch
@devup-ui/rsbuild-plugin@1.0.67 → 1.0.68 - packages/rsbuild-plugin/package.jsonPatch
@devup-ui/vite-plugin@1.0.73 → 1.0.74 - packages/vite-plugin/package.jsonPatch
@devup-ui/webpack-plugin@1.0.71 → 1.0.72 - packages/webpack-plugin/package.jsonPatch
|
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This was referenced Oct 2, 2026
Merge main history while preserving this PR implementation. No manual conflict resolutions.
Merge main history while preserving this PR implementation. No manual conflict resolutions.
Merge main history while preserving this PR implementation. No manual conflict resolutions.
Merge main history while preserving this PR implementation. No manual conflict resolutions.
Merge main history while preserving this PR implementation. No manual conflict resolutions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #689 (C 첫 번째 PR).
main에서 분기했습니다.문제
type표시를 버렸습니다. 그래서import { type DefaultTheme, ThemeProvider } from 'styled-components'가import { DefaultTheme } from "styled-components"라는 값 import로 바뀌었고, 원래 패키지가 런타임 의존성으로 남거나 존재하지 않는 export를 읽었습니다(60-exported-types의 타입 4개도 같은 문제).const spin = keyframes\...`은 문자열이 되는데spin.getName()은 그대로 남아 모듈을 평가할 때TypeError`가 났습니다.변경
typespecifier는 원래 패키지에import type { ... }로 따로 남깁니다.import type선언 전체는 변환하지 않습니다.keyframes()결과를 담은const에서 인자 없이.getName()을 부르면 생성된 keyframes 이름 문자열로 바꿉니다.assert_is_emptylint를 맞췄습니다. #706과 같은 수정이라 둘 중 나중에 병합되는 쪽에서 충돌이 날 수 있으며, 같은 내용이라 어느 쪽을 택해도 됩니다.동작 변화
새로 생기는 오류
남은 항목
검증
cargo clippy -D warnings(Rust 1.99),cargo test통과. 새 테스트test_type_only_imports_stay_type_only,test_keyframes_get_name을 추가했습니다.bun test5474개 통과, 커버리지 100%.53-default-theme,60-exported-types,61-keyframes-get-name을 probe로 확인했습니다.2026-10-08 업데이트: main 11790bef를 merge commit으로 병합했습니다; 충돌 파일: 없음; 충돌 없이 자동 병합했고, 이미 포함된 squash 원본은 조상 확인 후 ours 전략으로 중복 적용하지 않았습니다.