Skip to content

Confirm screen and project plans from one proposal table, accept stringified tool arguments - #100

Merged
owjs3901 merged 1 commit into
mainfrom
devfive/3099154426bffbeef8b62999b80bb038/devfive-relay-c70423/tolerant-tool-args
Oct 19, 2026
Merged

owjs3901 merged 1 commit into
mainfrom
devfive/3099154426bffbeef8b62999b80bb038/devfive-relay-c70423/tolerant-tool-args

Conversation

@devfive-relay-c70423

Copy link
Copy Markdown
Contributor
  • Coerce tool arguments sent as strings (e.g. "60000") to the schema's number/boolean/array/object instead of rejecting them.
  • devup_screen_plan / devup_project_plan draft returns proposal + proposalMarkdown: every open decision with its recommended answer, so the user confirms once (in their own language) instead of answering decision by decision.
  • confirm takes acceptRecommended: true; only changed rows go in answers.
  • A confirm that puts two screens on one URL writes nothing and returns details.conflict and details.retryAnswers with a distinct URL.
  • Tool description, ASK_INSTRUCTION and devup / devup-implementation-plan skills updated; manifest hashes refreshed; changepack added.

Tests: fmt, clippy clean; cargo test -p devup-mcp passes except two symlink tests that need symlink privilege on Windows (OS error 1314, pre-existing).


Submitted via Devfive hub. Employee: ; device: 3099154426bffbeef8b62999b80bb038

…ngified tool arguments

Draft returns proposal/proposalMarkdown (every open decision with its recommended answer); confirm takes acceptRecommended so only changed rows are sent; questions are shown in the user's language. A confirm placing two screens on one URL returns details.conflict and details.retryAnswers. Tool arguments sent as strings are coerced to the schema's number/boolean/array/object.
@owjs3901
owjs3901 marked this pull request as ready for review October 19, 2026 15:13
@owjs3901
owjs3901 merged commit 0a84c7c into main Oct 19, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant