Skip to content

Added the ability to send Windows Notifications#4

Open
Morthor wants to merge 2 commits intodev-fatal:mainfrom
Morthor:windows_notifications
Open

Added the ability to send Windows Notifications#4
Morthor wants to merge 2 commits intodev-fatal:mainfrom
Morthor:windows_notifications

Conversation

@Morthor
Copy link
Copy Markdown

@Morthor Morthor commented Mar 29, 2023

To be able to send Windows notifications the 'winsdk' library was added.

Comment thread monitor.py
def on_created(self, event):
send_message(self.token, self.chat_id)
print("Sending message...")
# Uncoment the following line to enable windows notifications
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be a more elegant way to enable windows notifications. I am currently working on mac support so I was thinking maybe the option to enable/disable windows notifications should be in the config

Suggested change
# Uncoment the following line to enable windows notifications
# Uncomment the following line to enable windows notifications

Comment thread windows_notification.py
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only this to add could be error handling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants