Repository navigation
FIX: Preserve fractional RMSE in polynomial extended-range optimization - #97
Merged
derb12 merged 2 commits intoOct 11, 2026
Merged
Conversation
Owner
|
Thanks for finding and fixing this bug! I just have two minor requested changes, otherwise this is good to go. |
derb12
requested changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
optimize_extended_rangeallocates its squared-error array with the dtype of the search grid. Polynomial degrees are integers, so fractional squared errors are truncated, often producing an all-zerormsecurve andmin_rmsefor normalized signals. The internal comparison still uses floating-point residuals, so the selected degree can disagree with the minimum of the reported curve.Allocate the error array as floating point and add signal-scaling regressions for
modpolyandimodpoly, with left, right and both-side extensions.Validation:
The change corrects reported errors; it does not change the optimizer's fitted result.
Type of Pull Request
Pull Request Checklist