Repository navigation
FIX: Keep adaptive-minmax constraints aligned with unsorted coordinates - #96
Merged
derb12 merged 2 commits intoOct 11, 2026
Merged
Conversation
derb12
requested changes
Oct 11, 2026
Owner
|
The segmentation faults in the Thanks again for both this and PR 97. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adaptive_minmaxbuilds endpoint constraints in sorted coordinate order. Whenweightsis omitted, it skips restoring those constraints to the input order, so reversed or shuffled coordinates constrain the wrong samples. This affects bothBaselineandBaseline2D.Always restore the constrained weights to input order. Keep the existing conditional restoration for the original weights. Add regressions for both polynomial methods and document that endpoints follow physical coordinates.
Validation:
These checks establish coordinate invariance; they do not assess the quality of the baseline model.
Type of Pull Request
Pull Request Checklist