chore(internal): fix mod export skips across checkouts - #7340
Open
tomas-zijdemans wants to merge 1 commit into
Open
tomas-zijdemans wants to merge 1 commit into
tomas-zijdemans wants to merge 1 commit into
Conversation
…me checkout paths The skip list is now matched against repo-relative paths, so a parent directory named `_something` or `*unstable*` no longer disables the check. Also anchors the `mod.ts` pattern so it can't skip `chmod.ts`, and removes the dead `uuid/v6.ts` entry.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7340 +/- ##
==========================================
- Coverage 95.04% 95.04% -0.01%
==========================================
Files 619 619
Lines 52012 52012
Branches 9450 9450
==========================================
- Hits 49434 49433 -1
Misses 2031 2031
- Partials 547 548 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tomas-zijdemans
force-pushed
the
chore/check-mod-exports-skip-paths
branch
from
September 28, 2026 17:41
fc99637 to
3fbdeba
Compare
lint:mod-exports skipping every file under some checkout pathslint:mod-exports skipping every file under some checkout paths
lint:mod-exports skipping every file under some checkout pathsThis branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lint:mod-exportsmatched its skip list against absolute paths, so the directory you cloned std into could switch the check off. With a checkout at/private/tmp/_probe/std, the/(\/|\\)_/pattern matches/_probeand every file gets skipped. An unexportedasync/planted.tspasses without a warning. A parent directory with "unstable" in its name does the same thing through/unstable/. CI runs on GitHub-hosted runners (/home/runner/work/std/std), so this only hits local runs and self-hosted runners, which check out under_work.The patterns now run against the path relative to the repo root (
uuid/v1.ts), with/separators on every platform. That also drops the(\/|\\)alternation from each entry.Also in here:
/mod\.ts$/becomes/\/mod\.ts$/. The old pattern also skipped any file whose name ends inmod.ts, so a stablefs/chmod.tswould never be checked.uuid/v6.tsentry. That file doesn't exist. The v6 module isunstable_v6.ts, which/unstable/already covers.new Set<string>()instead ofnew Set().Testing:
deno task lint:mod-exportspasses on main. I planted an unexportedasync/planted.tsandfs/chmod.tsin worktrees at/private/tmp/_probe/stdand/private/tmp/unstable-probe/std, and both files warn in both. I also removed each named skip entry one at a time to confirm it still suppresses a real warning.Heads-up: my #7335 (dotenv removal) edits the
dotenv/load.tsline in this list, so whichever lands second needs a one-line rebase.I used Claude Code to help investigate and write this change.