test(fmt,internal,cli/unstable): fix test failures with NO_COLOR - #7334
Open
miso-devel wants to merge 4 commits into
Open
miso-devel wants to merge 4 commits into
miso-devel wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7334 +/- ##
========================================
Coverage 95.04% 95.04%
========================================
Files 619 618 -1
Lines 52012 51757 -255
Branches 9450 9401 -49
========================================
- Hits 49434 49192 -242
+ Misses 2031 2022 -9
+ Partials 547 543 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7322.
When
NO_COLORis set, the implementation correctly disables colored output. However, several tests infmt,internal, andclialways expect ANSI escape codes, so they fail depending on the caller's environment.This PR makes those tests explicitly enable colors instead of relying on the environment. It uses
stubPropertyto setDeno.noColortofalse. For modules that capture the setting at initialization, the tests use dynamic imports so the stub is applied before the modules are loaded. For code that reads the setting at runtime, the stub is applied within the relevant tests.Testing
Ran each test file individually with
NO_COLOR=1before and after the changes:fmt/colors_test.tsinternal/styles_test.tscli/unstable_spinner_test.tsfmt/printf_test.tsThe existing
noColorsubprocess test passed both before and after the changes.