Skip to content

Msg bug xsup71559#44916

Merged
nbensalm-palo merged 4 commits into
masterfrom
msg-bug-xsup71559
Jul 1, 2026
Merged

Msg bug xsup71559#44916
nbensalm-palo merged 4 commits into
masterfrom
msg-bug-xsup71559

Conversation

@nbensalm-palo

Copy link
Copy Markdown
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/XSUP-71559

Description

Fixed an issue where downloading an eDiscovery export file caused subsequent commands to fail with a Unauthorized error.

Must have

  • Tests
  • Documentation

@nbensalm-palo nbensalm-palo added ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Jun 30, 2026
@content-bot

Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Jun 30, 2026
@marketplace-ai-reviewer

Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown

@marketplace-ai-reviewer

Copy link
Copy Markdown
Contributor
🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! Thanks for your contribution to the Microsoft Graph Security pack. I've reviewed the code and left a few minor suggestions to help polish things up. The feedback mostly focuses on extracting hardcoded values, ensuring test mock accuracy, and a couple of quick metadata and typo tweaks. Great work overall!

Additionally, please address the following file-level notes:

  • Packs/MicrosoftGraphSecurity/Integrations/MicrosoftGraphSecurity/MicrosoftGraphSecurity.py: Consider extracting the hardcoded Purview scope "b26e684c-5068-4120-a679-64a5d2c909d9/.default" used in download_export_file into a constant at the top of the file (e.g., PURVIEW_EDISCOVERY_SCOPE).
  • Packs/MicrosoftGraphSecurity/pack_metadata.json: The vendor name (e.g., "Microsoft") is missing from the keywords list. Please add it to improve searchability.

@Shellyber, @noydavidi, @nbensalm-palo please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

Comment thread Packs/MicrosoftGraphSecurity/ReleaseNotes/2_5_3.md Outdated
@noydavidi noydavidi self-requested a review June 30, 2026 13:59

@noydavidi noydavidi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job getting to the bottom of that bug! 🔥

@nbensalm-palo nbensalm-palo enabled auto-merge (squash) June 30, 2026 14:09
@content-bot

Copy link
Copy Markdown
Contributor

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: failed
Report ID: 9a5e2ca2aa796251

📋 Triage Report
💡 Resolutions are available in the full report.

⚠️ AI-generated triage. Validate before acting.

@content-bot

Copy link
Copy Markdown
Contributor

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@nbensalm-palo nbensalm-palo merged commit 3318818 into master Jul 1, 2026
21 of 23 checks passed
@nbensalm-palo nbensalm-palo deleted the msg-bug-xsup71559 branch July 1, 2026 14:38
socautomator pushed a commit to socautomator/content that referenced this pull request Jul 3, 2026
Fixed an issue where downloading an eDiscovery export file caused subsequent commands to fail with a Unauthorized error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants