Bump Node 20 actions to Node 24 - #166
Merged
Merged
Conversation
GitHub deprecated the Node 20 runtime, and runners now force Node 20 actions onto Node 24, which actions/configure-pages@v1 in particular can't handle, breaking the docs build during post-job cleanup (10/20 recent BuildDocsOnWikiEdit runs failing). Bump actions/checkout v4->v7, actions/upload-artifact v4->v7, actions/cache v4->v6, actions/configure-pages v1->v6, and actions/deploy-pages v4->v5, all of which now declare node24. Also update the local buildindex composite action from node20 to node24. Fixes bond-lab/sleeper-service#2
Test run on this branch (31493938635) confirmed build succeeds, but still emitted the Node 20 deprecation warning: upload-pages-artifact@v3 internally calls actions/upload-artifact@v4. v5 pins that internal call to upload-artifact@v7 (node24), closing the last gap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/configure-pages@v1can't handle, breaking the docs build during post-job cleanup (10/20 recentBuildDocsOnWikiEditruns failing).actions/checkoutv4→v7,actions/upload-artifactv4→v7,actions/cachev4→v6,actions/configure-pagesv1→v6, andactions/deploy-pagesv4→v5 — all now declarenode24../.github/actions/buildindexcomposite action fromnode20tonode24.Fixes bond-lab/sleeper-service#2
Test plan
yaml.safe_load(done locally)BuildDocsviaworkflow_dispatchon this branch and confirm it completes without the post-job cleanup failure