Fix CLI test summary accounting and exit status - #184
Merged
Conversation
Count only named final test events, report package failures separately, and persist measured wall-clock duration. Preserve the go test pipeline status after rendering the summary so test and compilation failures reach make.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Old versus corrected semantics
Previously every pass, fail, and skip event was counted as a test, including null-Test package events, and Duration summed overlapping test, subtest, parent, and package elapsed values. Pipeline consumers could also hide a nonzero go test status.
Now only final events with a non-null Test field count as individual executions. Package/build failures are reported separately, duration is measured around go test, and the original go test status is returned after the summary is displayed.