Skip to content

Fix CLI test summary accounting and exit status - #184

Merged
mikehorgan-dell merged 1 commit into
mainfrom
fix/cli-test-summary
Sep 2, 2026
Merged

Fix CLI test summary accounting and exit status#184
mikehorgan-dell merged 1 commit into
mainfrom
fix/cli-test-summary

Conversation

@mikehorgan-dell

@mikehorgan-dell mikehorgan-dell commented Sep 2, 2026

Copy link
Copy Markdown
Member

Summary

  • count only named final Go test events, including named parents and subtests
  • exclude package completion events from test totals, percentages, and package breakdowns
  • report package and build failures separately with captured compiler output
  • measure and persist actual go test wall-clock duration for parse-only summaries
  • preserve the original go test status through the progress pipeline and return it after rendering the summary
  • clear stale failure reports and duration metadata before each run

Old versus corrected semantics

Previously every pass, fail, and skip event was counted as a test, including null-Test package events, and Duration summed overlapping test, subtest, parent, and package elapsed values. Pipeline consumers could also hide a nonzero go test status.

Now only final events with a non-null Test field count as individual executions. Package/build failures are reported separately, duration is measured around go test, and the original go test status is returned after the summary is displayed.

Count only named final test events, report package failures separately, and persist measured wall-clock duration. Preserve the go test pipeline status after rendering the summary so test and compilation failures reach make.
@mikehorgan-dell
mikehorgan-dell merged commit 9bb92fb into main Sep 2, 2026
6 checks passed
@mikehorgan-dell
mikehorgan-dell deleted the fix/cli-test-summary branch September 2, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant