Structure change to support PowerFlex 5.0 - #44
Merged
Conversation
Signed-off-by: Luis Liu <luis_liu@dell.com>
Signed-off-by: Luis Liu <luis_liu@dell.com>
baoy1
requested review from
Bhavneet-Sharma,
P-Cao,
RayLiu7,
forrestxia,
tanh17,
taohe1012 and
vangork
July 30, 2025 02:43
RayLiu7
reviewed
Jul 30, 2025
|
|
||
| return response | ||
|
|
||
| def get_statistics_for_all_storage_nodes(self, ids=None, properties=None): |
Contributor
There was a problem hiding this comment.
Hi @baoy1, would it be better if you make this method common and move resource_type to the params as well? So other modules can call this method with specific resource_type, ids and properties to be retrieved.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 94.24% 94.74% +0.49%
==========================================
Files 48 56 +8
Lines 2851 3443 +592
==========================================
+ Hits 2687 3262 +575
- Misses 164 181 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Luis Liu <luis_liu@dell.com>
rename token.py to powerflex_token.py to avoid python native token conflict
baoy1
force-pushed
the
baoy1/powerflex_gen2
branch
from
July 30, 2025 15:51
8ae26a7 to
982f7b4
Compare
taohe1012
reviewed
Aug 1, 2025
| @@ -0,0 +1,26 @@ | |||
| # Copyright (c) 2024 Dell Inc. or its subsidiaries. | |||
Contributor
There was a problem hiding this comment.
we may need to use 2025 cp
| LOG.error(msg) | ||
| raise exceptions.PowerFlexClientException(msg) | ||
|
|
||
| # def query_selected_statistics(self, properties, ids=None): |
Contributor
There was a problem hiding this comment.
some useless codes could be removed
|
|
||
|
|
||
| # class LinkSchema(base_client.BaseSchema): | ||
| # rel = fields.Str( |
Contributor
There was a problem hiding this comment.
some useless codes could be removed
taohe1012
approved these changes
Aug 4, 2025
RayLiu7
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Structure change to support PowerFlex 5.0