Fix: NFS directory creation and add NFS server reachability validation - #5082
Merged
sujit-jadhav merged 2 commits intoAug 28, 2026
Merged
Conversation
SAYUK09
force-pushed
the
fix/orchestrator-nfs
branch
from
August 28, 2026 07:03
2b24a6a to
a3a64fc
Compare
…hability validation. Signed-off-by: sayuri <sayuri.kamble@dell.com>
…alidation Move Jinja templates to end of task name fields to comply with ansible-lint rule name[template]. The mount name is preserved in task messages for debugging. Signed-off-by: sayuri <sayuri.kamble@dell.com>
SAYUK09
force-pushed
the
fix/orchestrator-nfs
branch
from
August 28, 2026 07:56
b85c17b to
9c5ecc0
Compare
sujit-jadhav
approved these changes
Aug 28, 2026
snarthan
approved these changes
Aug 28, 2026
sujit-jadhav
merged commit Aug 28, 2026
208e1cc
into
dell:issue-4849-omnia-modernization
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a critical bug where NFS directories (ctld_track, openldap, slurm, slurm_backups) were not being created during Slurm/Kubernetes provisioning, and adds proactive validation to check NFS server reachability before provisioning begins.
Changes
mount_configrole was not actually mounting NFS shares on the OIM, preventing directory creation. Addedmount_config_mode: "oim-mount"to:provision_slurm.yml- mounts NFS for Slurm config directory creationprovision_kubernetes.yml- mounts NFS for K8s config directory creationmount_config/tasks/main.yml- skip cloud-init generation when in oim-mount modeFix OpenCHAMI URL variable collision - The
validate_provisioningrole was usingcluster_namewhich gets overwritten byslurm_config(fromopenldap to slurm_cluster), causing DNS resolution failures.Changed to use stable
hostvars['localhost']['oim_node_name']anddomain_nameinstead.Fix incorrect variable name - Changed
orchestrator_input_dirtoomnia_project_input_dirin generate_inventories/tasks/main.yml for HA config file path resolution.Add NFS server reachability validation - New validation task that:
storage_config.ymlandomnia_config.ymlnfs_storage_namereferences from enabled features (slurm/k8s)slurm_support,ucx_support, andopenmpi_supporttoprepare_orchestrator.ymlso downstream roles can correctly check these flags.Testing