Skip to content

chore: remove unused _HAYSTACK_TO_PROVIDER_GENERATION_KWARGS #12429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sjrl merged 2 commits into from
Aug 21, 2026
Merged

chore: remove unused _HAYSTACK_TO_PROVIDER_GENERATION_KWARGS #12429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dca3a1
remove
sjrl Aug 21, 2026
4b6f975
remove from utils
sjrl Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions haystack/components/generators/chat/openai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,6 @@ class OpenAIChatGenerator:
```
"""

_HAYSTACK_TO_PROVIDER_GENERATION_KWARGS: ClassVar[dict[str, str]] = {"max_output_tokens": "max_completion_tokens"}

SUPPORTED_MODELS: ClassVar[list[str]] = [
"gpt-5-mini",
"gpt-5-nano",
Expand Down
2 changes: 0 additions & 2 deletions haystack/components/generators/chat/openai_responses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,6 @@ class OpenAIResponsesChatGenerator:
```
"""

_HAYSTACK_TO_PROVIDER_GENERATION_KWARGS: ClassVar[dict[str, str]] = {"max_output_tokens": "max_output_tokens"}

SUPPORTED_MODELS: ClassVar[list[str]] = [
"gpt-5-mini",
"gpt-5-nano",
Expand Down
41 changes: 0 additions & 41 deletions haystack/components/generators/chat/utils.py
View file
Open in desktop

This file was deleted.

8 changes: 1 addition & 7 deletions test/components/generators/chat/test_azure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

import haystack.components.generators.chat.azure as azure_chat_module
from haystack import Pipeline, component
from haystack.components.generators.chat import AzureOpenAIChatGenerator, OpenAIChatGenerator
from haystack.components.generators.chat import AzureOpenAIChatGenerator
from haystack.components.generators.utils import print_streaming_chunk
from haystack.dataclasses import ChatMessage, ToolCall
from haystack.tools import ComponentTool, Tool
Expand Down Expand Up @@ -78,12 +78,6 @@ def tools():


class TestAzureOpenAIChatGenerator:
def test_haystack_to_provider_generation_kwargs(self) -> None:
assert (
AzureOpenAIChatGenerator._HAYSTACK_TO_PROVIDER_GENERATION_KWARGS
is OpenAIChatGenerator._HAYSTACK_TO_PROVIDER_GENERATION_KWARGS
)

def test_supported_models(self) -> None:
"""SUPPORTED_MODELS is a non-empty list of strings."""
models = AzureOpenAIChatGenerator.SUPPORTED_MODELS
Expand Down
8 changes: 1 addition & 7 deletions test/components/generators/chat/test_azure_responses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from pydantic import BaseModel

from haystack import Pipeline, component
from haystack.components.generators.chat import AzureOpenAIResponsesChatGenerator, OpenAIResponsesChatGenerator
from haystack.components.generators.chat import AzureOpenAIResponsesChatGenerator
from haystack.components.generators.utils import print_streaming_chunk
from haystack.dataclasses import ChatMessage, ToolCall
from haystack.tools import ComponentTool, Tool
Expand Down Expand Up @@ -75,12 +75,6 @@ def tools():


class TestInitialization:
def test_haystack_to_provider_generation_kwargs(self) -> None:
assert (
AzureOpenAIResponsesChatGenerator._HAYSTACK_TO_PROVIDER_GENERATION_KWARGS
is OpenAIResponsesChatGenerator._HAYSTACK_TO_PROVIDER_GENERATION_KWARGS
)

def test_supported_models(self) -> None:
"""SUPPORTED_MODELS is a non-empty list of strings."""
models = AzureOpenAIResponsesChatGenerator.SUPPORTED_MODELS
Expand Down
5 changes: 0 additions & 5 deletions test/components/generators/chat/test_openai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,11 +190,6 @@ def tools():


class TestOpenAIChatGenerator:
def test_haystack_to_provider_generation_kwargs(self) -> None:
assert OpenAIChatGenerator._HAYSTACK_TO_PROVIDER_GENERATION_KWARGS == {
"max_output_tokens": "max_completion_tokens"
}

def test_supported_models(self) -> None:
"""SUPPORTED_MODELS is a non-empty list of strings."""
models = OpenAIChatGenerator.SUPPORTED_MODELS
Expand Down
5 changes: 0 additions & 5 deletions test/components/generators/chat/test_openai_responses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,6 @@ def __call__(self, chunk: StreamingChunk) -> None:


class TestInitialization:
def test_haystack_to_provider_generation_kwargs(self) -> None:
assert OpenAIResponsesChatGenerator._HAYSTACK_TO_PROVIDER_GENERATION_KWARGS == {
"max_output_tokens": "max_output_tokens"
}

def test_supported_models(self) -> None:
"""SUPPORTED_MODELS is a non-empty list of strings."""
models = OpenAIResponsesChatGenerator.SUPPORTED_MODELS
Expand Down
33 changes: 0 additions & 33 deletions test/components/generators/chat/test_utils.py
View file
Open in desktop

This file was deleted.

Loading