Skip to content

fix!: require unsafe loading for serialized Jinja filters - #12415

Merged
sjrl merged 2 commits into
mainfrom
security/gate-serialized-jinja-filters
Aug 21, 2026
Merged

fix!: require unsafe loading for serialized Jinja filters#12415
sjrl merged 2 commits into
mainfrom
security/gate-serialized-jinja-filters

Conversation

@sjrl

@sjrl sjrl commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Related Issues

Proposed Changes:

Require Pipeline.loads(..., unsafe=True) to load jinja2 custom filters since they allow for code execution at load time.

How did you test it?

New tests

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@sjrl
sjrl requested a review from a team as a code owner August 20, 2026 07:03
@sjrl
sjrl requested review from davidsbatista and removed request for a team August 20, 2026 07:03
@vercel

vercel Bot commented Aug 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
haystack-docs Ignored Ignored Preview Aug 20, 2026 7:19am

Request Review

@sjrl
sjrl requested review from julian-risch and removed request for davidsbatista August 20, 2026 07:03
@sjrl

sjrl commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

@julian-risch tagging you for review since we talked about this yesterday

@sjrl sjrl self-assigned this Aug 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  haystack/components/converters
  output_adapter.py
  haystack/components/routers
  conditional_router.py
Project Total  

This report was generated by python-coverage-comment-action

@julian-risch julian-risch changed the title fix: require unsafe loading for serialized Jinja filters fix!: require unsafe loading for serialized Jinja filters Aug 21, 2026
@sjrl
sjrl merged commit cf4cadb into main Aug 21, 2026
24 checks passed
@sjrl
sjrl deleted the security/gate-serialized-jinja-filters branch August 21, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants