Skip to content

tests: FalkorDBDocumentStore removing duplicated tests already covered by haystack Mixin tests + overriding one - #3788

Merged
davidsbatista merged 2 commits into
mainfrom
test/consolidate-metadata-unique-values-falkordb
Aug 26, 2026
Merged

tests: FalkorDBDocumentStore removing duplicated tests already covered by haystack Mixin tests + overriding one#3788
davidsbatista merged 2 commits into
mainfrom
test/consolidate-metadata-unique-values-falkordb

Conversation

@davidsbatista

@davidsbatista davidsbatista commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Related Issues

Proposed changes

  • test_get_metadata_field_unique_values_distinct_types expects int, float, str and bool values sharing the same metadata field name to all come back as distinct. FalkorDB fails this because of a Cypher limitation:

    WITH DISTINCT d.priority AS val   -- 1 and 1.0 collapse into one value

    Verified live: a per-node property read correctly preserves each value's own
    type, but Cypher's DISTINCT treats the int 1 and the float 1.0 as equal,
    collapsing them into a single value (3 distinct values instead of 4). Not
    fixable in code.

    Fix: adapted the test to use one metadata field per type instead of one
    shared field (matching the same pattern applied to other document stores
    hitting this limitation), and used a fractional float (1.5) to sidestep the
    int/float ambiguity. Documented the limitation in the docstring and an inline
    comment.

Checklist

@github-actions github-actions Bot added integration:falkordb type:documentation Improvements or additions to documentation labels Aug 14, 2026
@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Coverage report (falkordb)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  integrations/falkordb/src/haystack_integrations/document_stores/falkordb
  document_store.py
Project Total  

This report was generated by python-coverage-comment-action

@davidsbatista davidsbatista changed the title tests: FalkorDBDocumentStore removing duplicated tests already covered by haystack Mixin tests tests: FalkorDBDocumentStore removing duplicated tests already covered by haystack Mixin tests + overriding one Aug 25, 2026
@davidsbatista
davidsbatista marked this pull request as ready for review August 25, 2026 17:33
@davidsbatista
davidsbatista requested a review from a team as a code owner August 25, 2026 17:33
@davidsbatista
davidsbatista requested review from sjrl and removed request for a team August 25, 2026 17:33

@sjrl sjrl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@davidsbatista
davidsbatista merged commit 2c84e93 into main Aug 26, 2026
17 of 18 checks passed
@davidsbatista
davidsbatista deleted the test/consolidate-metadata-unique-values-falkordb branch August 26, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:falkordb type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants