tests: FalkorDBDocumentStore removing duplicated tests already covered by haystack Mixin tests + overriding one - #3788
Merged
davidsbatista merged 2 commits intoAug 26, 2026
Conversation
Contributor
Coverage report (falkordb)Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
FalkorDBDocumentStore removing duplicated tests already covered by haystack Mixin testsFalkorDBDocumentStore removing duplicated tests already covered by haystack Mixin tests + overriding one
davidsbatista
marked this pull request as ready for review
August 25, 2026 17:33
davidsbatista
deleted the
test/consolidate-metadata-unique-values-falkordb
branch
August 26, 2026 06:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed changes
test_get_metadata_field_unique_values_distinct_typesexpects int, float, str and bool values sharing the same metadata field name to all come back as distinct. FalkorDB fails this because of a Cypher limitation:Verified live: a per-node property read correctly preserves each value's own
type, but Cypher's DISTINCT treats the int 1 and the float 1.0 as equal,
collapsing them into a single value (3 distinct values instead of 4). Not
fixable in code.
Fix: adapted the test to use one metadata field per type instead of one
shared field (matching the same pattern applied to other document stores
hitting this limitation), and used a fractional float (1.5) to sidestep the
int/float ambiguity. Documented the limitation in the docstring and an inline
comment.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.