Conversation
Collaborator
🤖 cc_bot Code ReviewLLM API 配额已用尽。 Files reviewed: 0 Issues found: ❌ Review incomplete — LLM response could not be parsed |
Author
|
can you re do the code review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject zero and negative values passed to
set_block_size_multiple_of.These values are currently stored without validation and later used by the
SM90 and SM100 kernel-selection heuristics. A zero value can produce
modulo-by-zero or a candidate loop with a zero increment.
This change fails early with a
RuntimeErrorand adds regression coverage forboth scalar and
(M, N)inputs.Testing
python -m compileall -q tests/test_runtime.pygit diff --check