Skip to content

fix: reject non-positive block size multiples - #428

Open
nisbenz wants to merge 1 commit into
deepseek-ai:mainfrom
nisbenz:fix/validate-block-size-multiples
Open

nisbenz wants to merge 1 commit into
deepseek-ai:mainfrom
nisbenz:fix/validate-block-size-multiples

Conversation

@nisbenz

@nisbenz nisbenz commented Sep 7, 2026

Copy link
Copy Markdown

Summary

Reject zero and negative values passed to set_block_size_multiple_of.

These values are currently stored without validation and later used by the
SM90 and SM100 kernel-selection heuristics. A zero value can produce
modulo-by-zero or a candidate loop with a zero increment.

This change fails early with a RuntimeError and adds regression coverage for
both scalar and (M, N) inputs.

Testing

  • python -m compileall -q tests/test_runtime.py
  • git diff --check

@ds-review-bot

Copy link
Copy Markdown
Collaborator

🤖 cc_bot Code Review

LLM API 配额已用尽。

Files reviewed: 0

Issues found: ❌ Review incomplete — LLM response could not be parsed
Error: budget_exceeded

@nisbenz

nisbenz commented Sep 15, 2026

Copy link
Copy Markdown
Author

can you re do the code review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants