docs: fix stale test file link in README - #423
Open
pengfaming wants to merge 1 commit into
Open
pengfaming wants to merge 1 commit into
pengfaming wants to merge 1 commit into
Conversation
Collaborator
🤖 ds-review-bot Code Reviewv6新链接均指向现存且包含相关 GEMM 测试的文件，正确修复了失效链接，未发现功能性问题。 v5Docs-only fix: README's Utilities section link to the removed tests/test_core.py is updated to point to tests/test_fp8_fp4.py and tests/test_bf16.py, both of which exist in the repo and contain the relevant GEMM tests. Change is minimal, correct, and matches the description. v4p本 MR 旨在修复 README 中指向已删除文件 tests/test_core.py 的失效链接，将其更新为现有的 tests/test_fp8_fp4.py 与 tests/test_bf16.py。变更范围仅一行文档，两个目标测试文件均存在，且仓库中已无残留的 test_core.py 引用，修改正确。 Files reviewed: 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The README's Utilities section links to
tests/test_core.py, which no longer exists (removed in the 2025-08 refactor). The core GEMM tests now live intests/test_fp8_fp4.py(FP8/FP4, grouped GEMMs) andtests/test_bf16.py(BF16 GEMMs). Update the link to point to both.Why
Fixes a broken link in the README so readers reach the actual test code.
How I checked
tests/test_core.pyreturns 404 onmain.tests/test_fp8_fp4.pyandtests/test_bf16.pyexist onmainand contain the relevant GEMM tests.