Repository navigation
fix(web): move hardcoded feed placeholder to i18n - #1227
Closed
Schro-code wants to merge 2 commits into
Closed
Schro-code wants to merge 2 commits into
Schro-code wants to merge 2 commits into
Conversation
added 2 commits
October 14, 2026 17:24
The custom source endpoint placeholder was the only hardcoded English string in the source modal — all sibling fields already used S.library.* keys. Move it to S.library.feedPlaceholder for consistency.
The previous commit added the key to en.ts but missed zh.ts, breaking the type check since both bundles must be structurally identical.
Author
|
Closing to re-open against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The custom source endpoint placeholder (
"https://your-service/utopia-feed") was the only hardcoded English string in the source modal — all sibling fields already usedS.library.*keys.This moves it to
S.library.feedPlaceholderfor consistency with the rest of the form.Changes
web/src/i18n/en.ts— addfeedPlaceholderkeyweb/src/pages/Library.tsx— replace hardcoded string with i18n referenceTest plan
zh.ts