Repository navigation
An attribute can be created from the ontology table, and relation buttons say relation - #1225
Merged
Merged
Conversation
…tons say relation The attributes tab of the ontology table had no button: the attribute dialog took its class from the class panel that opened it, so the only way in was to open a class first, and nothing on the tab said so. A user looking at it asked whether attributes could be added by hand at all. The tab now has New attribute; opened from there, the dialog asks which class the attribute belongs to and will not save without one. The relations tab, its button and the relation dialog used the Properties strings, which read 属性 in Chinese, the word the attributes tab uses. They now say 关系 / Relations (the edit title already did). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Wayland Yang <wayland0916@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A user looking at the ontology table asked whether attributes can be added by hand at all. They can, but only from a class's panel: the attributes tab had no button, because the attribute dialog took its class from the panel that opened it, and nothing on the tab pointed there. The relations tab beside it made it worse: in Chinese its label, its button and the relation dialog all said 属性 (from the
Propertiesstrings), the same word as the attributes tab.What changes
tabProperties/newProperty/editPropertyread 关系 / 新建关系 and Relations / New relation / Edit relation. Every use of them is a relation (the rail tab, the table button, the relation dialog, the connect dialog); the Chinese edit title already said 编辑关系.Checked
tsc --noEmit,pnpm buildandpnpm test(268 tests) pass. The page has no component tests, so none is added.relation_type_domains). The relations tab's button reads New relation.🤖 Generated with Claude Code