Skip to content

An attribute can be created from the ontology table, and relation buttons say relation - #1225

Merged
WaylandYang merged 1 commit into
devfrom
fix/an-attribute-can-be-made-from-the-table
Oct 14, 2026
Merged

WaylandYang merged 1 commit into
devfrom
fix/an-attribute-can-be-made-from-the-table

Conversation

@WaylandYang

Copy link
Copy Markdown
Contributor

Why

A user looking at the ontology table asked whether attributes can be added by hand at all. They can, but only from a class's panel: the attributes tab had no button, because the attribute dialog took its class from the panel that opened it, and nothing on the tab pointed there. The relations tab beside it made it worse: in Chinese its label, its button and the relation dialog all said 属性 (from the Properties strings), the same word as the attributes tab.

What changes

  • The attributes tab has New attribute. Opened from there, the dialog asks which class the attribute belongs to (the existing class search select) and does not save without one. Opened from a class panel, it behaves as before.
  • tabProperties / newProperty / editProperty read 关系 / 新建关系 and Relations / New relation / Edit relation. Every use of them is a relation (the rail tab, the table button, the relation dialog, the connect dialog); the Chinese edit title already said 编辑关系.

Checked

  • tsc --noEmit, pnpm build and pnpm test (268 tests) pass. The page has no component tests, so none is added.
  • In the browser against a local server: created a class, opened Attributes → New attribute, Save stayed disabled until a class was chosen, saved, and the attribute appeared on the table under that class (and in relation_type_domains). The relations tab's button reads New relation.

🤖 Generated with Claude Code

…tons say relation

The attributes tab of the ontology table had no button: the attribute
dialog took its class from the class panel that opened it, so the only
way in was to open a class first, and nothing on the tab said so. A user
looking at it asked whether attributes could be added by hand at all.
The tab now has New attribute; opened from there, the dialog asks which
class the attribute belongs to and will not save without one.

The relations tab, its button and the relation dialog used the
Properties strings, which read 属性 in Chinese, the word the attributes
tab uses. They now say 关系 / Relations (the edit title already did).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Wayland Yang <wayland0916@gmail.com>
@WaylandYang
WaylandYang merged commit 8b91697 into dev Oct 14, 2026
6 checks passed
@WaylandYang
WaylandYang deleted the fix/an-attribute-can-be-made-from-the-table branch October 14, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant