Enhance fee transaction sanity checks.#512
Conversation
d9e5529 to
921480c
Compare
|
I held off on merging this it runs on testnet for a while. I have seen the |
Confirm the existence of all of the inputs to fee transactions provided by clients. If any of the inputs do not exist, or are not known by the local dcrd instance, an error is returned to the client and the ticket is not registered with the VSP.
921480c to
ae1a117
Compare
|
I still see this error every few days, and in every case the ticket and fee transactions are eventually mined successfully which I think confirms my theory that the root cause is network propagation delay. Given that every wallet on the network is subject to this delay, every wallet using a VSP could potentially encounter this issue and need to send unnecessary retries and remain online longer than necessary. Given that the only real benefit of this PR is to give an earlier error to wallets which provide an invalid fee transaction, I don't think the trade-off of inconveniencing every other wallet on the network is worth it. |
Confirm the existence of all of the inputs to fee transactions provided by clients. If any of the inputs do not exist, or are not known by the local dcrd instance, an error is returned to the client and the ticket is not registered with the VSP.
Closes #508