peer: Remove deprecated PushGetBlocksMsg.#3703
Merged
Merged
Conversation
davecgh
force-pushed
the
peer_remove_getblocksmsg
branch
from
e2dd062 to
61332d1
Compare
jholdstock
reviewed
Jun 14, 2026
jholdstock
left a comment
jholdstock
left a comment
Member
There was a problem hiding this comment.
$ grep -ri "pushgetblocks" *
peer/doc.go:[Peer.PushAddrMsg], [Peer.PushGetBlocksMsg], and [Peer.PushGetHeadersMsg]
peer/doc.go:Finally, [Peer.PushGetBlocksMsg] and [Peer.PushGetHeadersMsg] will construct
davecgh
force-pushed
the
peer_remove_getblocksmsg
branch
from
61332d1 to
cbb125e
Compare
Member
Author
Removed references. |
davecgh
force-pushed
the
peer_remove_getblocksmsg
branch
from
cbb125e to
f6b178c
Compare
jholdstock
approved these changes
Jun 14, 2026
dajohi
approved these changes
Jun 23, 2026
The legacy getblocks protocol message hasn't been used for years since the syncing model was switched over to use headers-first semantics. This removes the method for sending the message, along with its associated tracking fields, since it has been deprecated for a long time and nothing actually uses it anymore. However, the listener for the message is retained since the server is still required to handle and respond to the message even though, in practice, nothing really should be sending them anymore. Removing the protocol message and handling would require a new protocol version and following the protocol message deprecation and removal schedule.
davecgh
force-pushed
the
peer_remove_getblocksmsg
branch
from
f6b178c to
79885a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy
getblocksprotocol message hasn't been used for years since the syncing model was switched over to use headers-first semantics.This removes the method for sending the message from the
peerpackage, along with its associated tracking fields, since it has been deprecated for a long time and nothing actually uses it anymore.However, the listener for the message is retained since the server is still required to handle and respond to the message even though, in practice, nothing really should be sending them anymore. Removing the protocol message and handling would require a new protocol version and following the protocol message deprecation and removal schedule.