Repository navigation
fix mcp reauthorization recovery - #432
Conversation
|
Preview removed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61067b687a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91f3373710
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
OAuth MCP connections could get stuck as failed when capability discovery or a tool request required renewed sign-in. Publish the authorization URL from the shared OAuth provider, transition the connection to authenticating, and recover the existing server ID after sign-in.
HTTP and SSE requests share one authorization flow per connection, avoiding the SDK's concurrent refresh race. Late 401 responses reuse renewed tokens; ordinary tool calls remain concurrent. Stale discovery results cannot overwrite authorization state.
Refresh retries failed connections and replaces expired sign-in links. If removal fails after closing the live session, refresh rebuilds it from the retained registration and preserves any pending sign-in. A missing registration produces an explicit error.
Calls interrupted by interactive authorization require an explicit retry; downstream tool errors and ordinary HTTP 403 responses retain their existing behavior.
Validation:
Docs: gsv-manual PR deathbyknowledge/gsv-manual#38