Repository navigation
preserve context and personal memory across compaction - #431
Conversation
|
@codex review Please focus on active-run ownership and tool/result grouping when installing handovers; cancellation, restart and repeated compaction; complete emergency-summary coverage within model budgets; and memory-review admission durability, deduplication, owner isolation and opt-out. Provider calls in the tests are mocked, so live model quality is still a separate draft-PR validation step. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Preview removed. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 433a7f98b3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review The teardown finding is fixed in f8b6d04 with an ordered Kernel-owned source queue and mandatory pre-teardown handoff. Please recheck that lifecycle and the original compaction boundaries. Also added a real Shell/Gateway test for repeated active-run handovers and fixed the prompt-editor catalog check. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8b6d04be9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please re-review the latest head, especially the pending memory-review lifecycle across Ship replacement and Crew reading archived slices after the source pid is killed. The last finding is fixed with the existing native filesystem/gzip path plus a Workers-compatible shell output limit, covered by a real gateway integration regression. Provider responses in automated tests remain mocked; real-model quality validation is still pending. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e4fba58bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review 7bd4b1d and 5e2209c: self-authored handovers now use the shared 40% retention policy, and archive reads stream through proc history --archive instead of a bounded gzip shell pipeline. In particular check the current-run/epoch fence, retention of recent complete tool groups, archive authorization and cancellation, and pagination. All 2,722 gateway unit tests and both continuity integration tests pass. The baseline deployment is separate; this change will initially go to staging only. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ad3727fae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This branch was successfully deployed
1 participant
Summary
Compaction previously summarized only the head and tail of long histories, could not reclaim completed steps during a long worker run, and presented internal summaries as Memory in Chat.
proc compact --summary. Install it after its current tools finish, preserving the current request, unseen results and recent complete exchanges. Self-authored and automatic compaction share the configured retention target: 40% of the usable input budget by default, including standing instructions, tools, handover and original messages. Cancellation and epoch changes fence stale requests.proc history --archivestreams readable archives page by page even after the source Process is gone. The existing responsibility-source setting can disable new reviews.No new service, account role or model-facing tool. Existing user-edited prompts remain unchanged.
Validation
Rollout
Deploy existing main to staging and production first. Merge this only after review and CI pass, then deploy the compaction change to staging only for further real-model testing. No customer contents are used for evaluation.
Pre-existing maintainer comments in
history/compaction-renderer.tsandzenModel.tsdescribe superseded behavior and remain unchanged under the comment-preservation rule.Docs
docs/is updated here. Companion GSV Manual PR: deathbyknowledge/gsv-manual#37; the exact reviewed revision f1aefe7 is pinned here; merge the companion before this runtime PR.