Repository navigation
allow empty dbnames in deadpool-postgres config - #501
Merged
Merged
Conversation
… attempt to connect to dbname=${user} as a default fallback
bikeshedder
added
enhancement
Collaborator
|
Makes sense. Yes! Thanks a lot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the underlying postgres driver interprets empty dbnames as using the username. this PR lets
config.dbname == Nonepass when creating thetokio_postgres::Config, deletes the error variant, and adds a test that replicatesbasic. much like how running the test suite requires thedeadpooldatabase to exist, the new defaultdb test will require that the database corresponding to the current username exists.