GH-177: ensure symlink-project adds /vendor/ and /web/ to gitignore - #178
Open
tormi wants to merge 1 commit into
Open
GH-177: ensure symlink-project adds /vendor/ and /web/ to gitignore#178tormi wants to merge 1 commit into
tormi wants to merge 1 commit into
Conversation
Collaborator
|
OK, I'll take this despite my reply in #25. Could you rework it so that we do nothing if .gitignore already exists? Lets assume the project knows what it is doing in that case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
After running the documented Drupal contrib setup flow,
.gitignoreis not updated automatically with/vendor/and/web/, which can lead to accidental commits of generated scaffold directories.How This PR Solves The Issue
ddev symlink-projectto ensure.gitignorecontains:/vendor//web/.gitignorecontent.Manual Testing Instructions
Then verify:
ddev symlink-project.gitignoreincludes/vendor/and/web/ddev symlink-projectagain and confirm no duplicate entries are addedAutomated Testing Overview
tests/full.bats:@test "ddev symlink-project updates gitignore"./tests/bats/bin/batswas not available until submodules are initialized.Release/Deployment Notes