Repository navigation
Conversation
pulls.listCommits serves only the newest 250 commits of a pull request, and GraphQL's pullRequest.commits has the same cap while still reporting the true totalCount. The GraphQL fallback therefore always ended in "returned 250 of N" and the check failed closed on every retry. At the cap, page repos.compareCommits(base.sha...head.sha) instead, with the pager the merge group path already uses. The range is rejected unless it is complete and contains every commit pulls.listCommits returned. The failure summary now carries the reason when there is no HTTP status. Fixes dcoapp#327 Assisted-by: Claude:claude-fable-5-2 claude-code Claude-Session: https://claude.ai/code/session_01W9Bas7vxoZujc8jZZ88DLq Signed-off-by: Giles Cope <gilescope@gmail.com>
|
@giles-bot is attempting to deploy a commit to the DCO App Team on Vercel. A member of the Team first needs to authorize it. |
gilescope
marked this pull request as ready for review
November 11, 2026 18:08
skylar-simoncelli
approved these changes
Nov 11, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #327.
Problem
A pull request with more than 250 commits can never get a DCO verdict. At 250
REST commits the app falls back to GraphQL
pullRequest.commits, but thatconnection has the same 250 cap while reporting the true
totalCount, so thecompleteness check always throws ("returned 250 of N") - hence
HTTP status: unknownon every retry.Measured on nodejs/node#66667 (340 commits):
pulls.listCommitspullRequest.commitstotalCount340compare/{base.sha}...{head.sha}, paginatedFix
repos.compareCommits(base.sha...head.sha)- the Listcommits family GitHub's docs point to - reusing the merge group pager.
pulls.listCommitsreturned.is what hid the cause in DCO fails on PRs with more than 250 commits #327.
Notes for review
pulls.listCommitsstays the source below 250, so ordinary pull requestsare untouched.
base.sha...head.shamatchedpull_request.commitson 40 of 40 sampledopen fork pull requests with old bases (kubernetes/kubernetes) and on the
merged 340-commit one above. A compare against the base ref returns 0
commits once merged, so shas are used.
🤖 Generated with Claude Code
https://claude.ai/code/session_01W9Bas7vxoZujc8jZZ88DLq