feat: Support for VR type "UV" #488
Open
PolarsBear wants to merge 4 commits intodcmjs-org:masterfrom
Open
Conversation
Admits further tests, in fact, leaves much to be desired
✅ Deploy Preview for dcmjs2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pieper
approved these changes
Apr 14, 2026
Collaborator
pieper
left a comment
pieper
left a comment
There was a problem hiding this comment.
This seems reasonable to me, thanks for the contribution 👍
I'd like another set of eyes though, so maybe @wayfarer3130 can take a look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In accordance with the (not so) new DICOM metadata standards, since 2019a, as stated in PS3.5, section 6.2 (see here), the VR type "UV", or "Unsigned 64 bit Very Long" describes, as one would expect, a 64 bit unsigned integer.
To comply with these standards and avoid interpreting these values as VR type "UN" (Unknown), I offer this contribution.
I attempted to keep things as close to the standard you've set as I could, but, in case of any insatisfaction, I am more than capable of reworking the code herein suggested.
The tests leave quite a bit to be desired. I must admit testing is not my greatest strong suit. Basic testing is in place for reading and writing, but more in-depth tests with real DICOM datasets would be welcome.
I couldn't find any documentation as to how I should write the Pull Request, so I hope this is acceptable
(Also, my first Pull Request, so I ask you to forgive me if something here isn't up to standard)