Repository navigation
[Backport]FLPATH-4946: Update readme for helm deployment (#86) - #92
Merged
jenniferubah merged 1 commit intoOct 15, 2026
Merged
Conversation
## Summary - Fix Helm README examples for multi-value `environmentAgent.embeddedSps` so commas survive bash and reach Helm’s --set parser. - Replace single-backslash escapes (\,) with double-backslash (\\,) in the guide and install/upgrade examples (container\\,vm, container\\,cluster). Fixes: https://redhat.atlassian.net/browse/FLPATH-4946 Assisted-By: Cursor AI Signed-off-by: Jennifer Ubah <cju.cipher@gmail.com> (cherry picked from commit 96b82b1)
jenniferubah
requested review from
LinskId,
NoamNakash,
gabriel-farache,
gpb88 and
tkiss28
October 15, 2026 14:20
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can hide the parts of a finding you never read, like the evidence or the agent prompt |
PR Summary by QodoFix comma escaping in Helm Environment Agent deployment examples
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
y-first
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
environmentAgent.embeddedSpsso commas survive bash and reach Helm’s --set parser.Fixes: https://redhat.atlassian.net/browse/FLPATH-4946
Assisted-By: Cursor AI
(cherry picked from commit 96b82b1)