Skip to content

[Backport]FLPATH-4946: Update readme for helm deployment (#86) - #92

Merged
jenniferubah merged 1 commit into
dcm-project:release/vm2from
jenniferubah:cherrypick-fix-readme
Oct 15, 2026
Merged

jenniferubah merged 1 commit into
dcm-project:release/vm2from
jenniferubah:cherrypick-fix-readme

Conversation

@jenniferubah

Copy link
Copy Markdown
Contributor

Summary

  • Fix Helm README examples for multi-value environmentAgent.embeddedSps so commas survive bash and reach Helm’s --set parser.
  • Replace single-backslash escapes (,) with double-backslash (\,) in the guide and install/upgrade examples (container\,vm, container\,cluster).

Fixes: https://redhat.atlassian.net/browse/FLPATH-4946

Assisted-By: Cursor AI

(cherry picked from commit 96b82b1)

## Summary

- Fix Helm README examples for multi-value
`environmentAgent.embeddedSps` so commas survive bash and reach Helm’s
--set parser.
- Replace single-backslash escapes (\,) with double-backslash (\\,) in
the guide and install/upgrade examples (container\\,vm,
container\\,cluster).

Fixes: https://redhat.atlassian.net/browse/FLPATH-4946

Assisted-By: Cursor AI

Signed-off-by: Jennifer Ubah <cju.cipher@gmail.com>
(cherry picked from commit 96b82b1)
@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can hide the parts of a finding you never read, like the evidence or the agent prompt

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Fix comma escaping in Helm Environment Agent deployment examples

📝 Documentation 🐞 Bug fix 🕐 Less than 5 minutes

Grey Divider

AI Description

• Correct comma escaping so multi-provider values reach Helm’s --set parser intact.
• Fix the container,vm and container,cluster upgrade examples.
Diagram

graph TD
  A["README examples"] --> B["Shell parsing"] --> C["Helm set parser"] --> D["Embedded SP value"]
Loading
High-Level Assessment

Keep the corrected unquoted examples: the extra backslash accounts for shell parsing while retaining the guide’s existing command style. Quoting each --set argument would also work but offers no clear advantage here.

Files changed (1) +3 / -3

Documentation (1) +3 / -3
README.mdCorrect escaping in multi-provider Helm examples +3/-3

Correct escaping in multi-provider Helm examples

• Changes the comma-escaping guidance and the 'container,vm' and 'container,cluster' upgrade commands from '\,' to '\\,'. This preserves the escape through shell parsing so Helm receives each provider list as a single value.

deploy/helm/dcm/README.md

@jenniferubah
jenniferubah merged commit 7ec51bf into dcm-project:release/vm2 Oct 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants