Fair ordering for deferred deletion claims - #65
Draft
gciavarrini wants to merge 7 commits into
Draft
gciavarrini wants to merge 7 commits into
gciavarrini wants to merge 7 commits into
Conversation
DB-backed claiming with optimistic updates on SQLite and SKIP LOCKED on Postgres. Assisted-By: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Assisted-By: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Second control-plane replica in compose. assert one cleanup delete publish per scheduler tick across replicas. Fail fast when the second replica is not reachable. Assisted-By: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Use compose profile ha so test-up stays single-replica. HA spec brings cp2 up on demand, polls health, and stops it after. Assisted-By: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Assisted-By: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Do not clear deletion_claimed_until when recording a publish attempt. Release claims on publish failure, lookup errors, and cycle cancel so retries are not blocked for the full TTL Assisted-By: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Deprioritize recently retried SCHEDULED deletions via last_deletion_attempt so newer backlog rows are not starved. Add SQLite and Postgres fairness tests Assisted-By: Claude (Anthropic) Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClaimPendingDeletionsnow prefers rows with nolast_deletion_attemptover recently retried backlog rows, withdeletion_requested_atas a deterministic tie-breaker.Applies to both Postgres (
SKIP LOCKED) and SQLite claim paths.With 101+
SCHEDULEDdeletions, a newer row is claimed on the next cleanup cycle once the oldest 100 have been attempted.Commits
This PR adds only 1 commit on top of #64:
Base PR #64 commit range is:
d4acaff..6a4de20Fixes
FLPATH-4866