enhance(cli): Echo request on --replay as well as editor queries#802
Merged
Conversation
When replaying a conversation turn, the message being sent comes from history rather than the terminal, so the user has no visual cue of what is about to be submitted. Previously, only editor-composed queries were echoed back before the assistant response; `--replay` was silently re-sent without any visible boundary. The echo condition is now captured in `should_echo_request`, which returns `true` whenever the user can't already see what's being sent: either because an editor took over the screen, or because the message was pulled from history via `--replay`. Plain inline queries are left unchanged — the user just typed them. Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When replaying a conversation turn, the message being sent comes from history rather than the terminal, so the user has no visual cue of what is about to be submitted. Previously, only editor-composed queries were echoed back before the assistant response;
--replaywas silently re-sent without any visible boundary.The echo condition is now captured in
should_echo_request, which returnstruewhenever the user can't already see what's being sent: either because an editor took over the screen, or because the message was pulled from history via--replay. Plain inline queries are left unchanged — the user just typed them.