Repository navigation
Replace the callable config group with a plain key - #80
Merged
Merged
Conversation
callable/callable.yaml only set callable: /model, but as a group on the plugin search path it turned callable into a config group for every lerna app on the machine. ccflow apps such as nbprint then could not override callable (++callable= fails with "force-add of config groups is not supported"), and neither could users of this package. A plain key in base.yaml composes the same config and can be overridden with callable=/<entry>. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
=======================================
Coverage 85.44% 85.44%
=======================================
Files 67 67
Lines 10063 10063
Branches 1250 1250
=======================================
Hits 8598 8598
Misses 1154 1154
Partials 311 311 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config/callable/callable.yamlonly setcallable: /model(# @package _global_). Because it's a group on thehydra.lernapluginssearch path, every lerna app on a machine with dau-sim installed seescallableas a config group. ccflow apps usecallableas a plain key, so++callable=/xthen fails with "force-add of config groups is not supported" (nbprint's multirun tests hit this). Users of dau-sim couldn't override it either:callable=/xlooked for a group option.callable: /modelis now a plain key inbase.yaml. The composed base config is identical, andcallable=/xand++callable=/xboth work. Since the group sat last in the defaults list, a selected config that setcallableused to be overridden back to/model; now its value is kept. No packaged config setscallable.