Skip to content

Replace the callable config group with a plain key - #80

Merged
timkpaine merged 1 commit into
mainfrom
callable-key
Oct 15, 2026
Merged

timkpaine merged 1 commit into
mainfrom
callable-key

Conversation

@timkpaine

Copy link
Copy Markdown
Member

config/callable/callable.yaml only set callable: /model (# @package _global_). Because it's a group on the hydra.lernaplugins search path, every lerna app on a machine with dau-sim installed sees callable as a config group. ccflow apps use callable as a plain key, so ++callable=/x then fails with "force-add of config groups is not supported" (nbprint's multirun tests hit this). Users of dau-sim couldn't override it either: callable=/x looked for a group option.

callable: /model is now a plain key in base.yaml. The composed base config is identical, and callable=/x and ++callable=/x both work. Since the group sat last in the defaults list, a selected config that set callable used to be overridden back to /model; now its value is kept. No packaged config sets callable.

callable/callable.yaml only set callable: /model, but as a group on the plugin search path it turned callable into a config group for every lerna app on the machine. ccflow apps such as nbprint then could not override callable (++callable= fails with "force-add of config groups is not supported"), and neither could users of this package. A plain key in base.yaml composes the same config and can be overridden with callable=/<entry>.

Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Test Results

521 tests  ±0   518 ✅ ±0   18s ⏱️ -5s
  1 suites ±0     3 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 7446af9. ± Comparison against base commit a91215a.

@codecov

codecov Bot commented Oct 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.44%. Comparing base (a91215a) to head (7446af9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   85.44%   85.44%           
=======================================
  Files          67       67           
  Lines       10063    10063           
  Branches     1250     1250           
=======================================
  Hits         8598     8598           
  Misses       1154     1154           
  Partials      311      311           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timkpaine
timkpaine merged commit 8c2b5dc into main Oct 15, 2026
4 checks passed
@timkpaine
timkpaine deleted the callable-key branch October 15, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant