Repository navigation
Carry each tile's module parameters in the capability contract - #217
Merged
Merged
Conversation
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The capability contract described each tile by registry identity, opcodes and config, but not the module parameters it was built with. A mask, exact-branch or hash key-mask dispatcher therefore looked the same to a planner matching against a resident shell, and the exact-branch mode drops every row whose key is not a branch id.
TileCapabilitygainsparams: every parameter the tile declares, at its override or its default. The manifest mapping carries them underparams. A mapping without them, as manifests written before this change are, reads as(), so a reader that needs a parameter treats it as unknown. The contract schema stays 1, following howreconfigurablewas added.